Visitar URL original
Fix and disable StrongNameSigning · pythonnet/pythonnet@56aee35 · GitHub
Skip to content

Commit 56aee35

Browse files
vmuriartvmuriart
committed
Fix and disable StrongNameSigning
It works better if they key is in the right folder and its being referenced when signing. It breaks InternalsVisibleTo though, disabling till have time to look into it. (not that it was actually enabled)
1 parent 2e5fab6 commit 56aee35

4 files changed

Lines changed: 6 additions & 4 deletions

File tree

‎setup.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,12 +104,12 @@ def _get_interop_filename():
104104

105105
def _get_source_files():
106106
"""Walk project and collect the files needed for ext_module"""
107-
for ext in (".sln", ".snk", ".config"):
107+
for ext in (".sln", ".config"):
108108
for path in glob.glob("*" + ext):
109109
yield path
110110

111111
for root, dirnames, filenames in os.walk("src"):
112-
for ext in (".cs", ".csproj", ".sln", ".snk", ".config", ".il",
112+
for ext in (".cs", ".csproj", ".snk", ".config", ".il",
113113
".py", ".c", ".h", ".ico"):
114114
for filename in fnmatch.filter(filenames, "*" + ext):
115115
yield os.path.join(root, filename)

pythonnet.snk renamed to src/pythonnet.snk

File renamed without changes.

‎src/runtime/Python.Runtime.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@
1616
<PythonBuildDir Condition=" '$(PythonBuildDir)' == '' ">$(SolutionDir)</PythonBuildDir>
1717
<!--If need to freeze language version: <LangVersion>5</LangVersion> !-->
1818
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
19-
<SignAssembly>true</SignAssembly>
19+
<SignAssembly>false</SignAssembly>
20+
<AssemblyOriginatorKeyFile>..\pythonnet.snk</AssemblyOriginatorKeyFile>
2021
</PropertyGroup>
2122
<PropertyGroup Condition=" '$(Platform)' == 'x86'">
2223
<PlatformTarget>x86</PlatformTarget>

‎src/testing/Python.Test.csproj‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@
1515
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\..\</SolutionDir>
1616
<PythonBuildDir Condition=" '$(PythonBuildDir)' == '' ">$(SolutionDir)</PythonBuildDir>
1717
<!--If need to freeze language version: <LangVersion>5</LangVersion> !-->
18-
<SignAssembly>true</SignAssembly>
18+
<SignAssembly>false</SignAssembly>
19+
<AssemblyOriginatorKeyFile>..\pythonnet.snk</AssemblyOriginatorKeyFile>
1920
<ErrorReport>prompt</ErrorReport>
2021
</PropertyGroup>
2122
<PropertyGroup Condition=" '$(Platform)' == 'x86'">

0 commit comments

Comments
 (0)