Repository navigation
Wait Until Page Contains: Add INFO with the value of the text to the Keyword results #1941
Description
Activity
I've handled this with PR #1965.
[Commenting here as compared to the PR to widen the circle of conversation]
@BastiaanTenBroeke24 the case you mention, where it is a variable passed in, is an interesting case because as you mention under normal logging the contents of the variable is not logged. Otherwise it is obvious what is the text. I admit I am a bit on the fence for the proposed change by @kiteretsu-daihyakka due to this .. "Should one not know what the message is they are checking?" (i.e. leave it as is) versus "It may not be clear and how then does one double check or confirm? Does not this change assist in the information provided and also put the information together at the point of need" (i.e. merge in the PR).
In a timely coincident, we were just discussing the larger question of error messages (#1933) at RoboCon with Sander (@Lakitna). This I think would fit in nicely with that discussion ..
Reacted by Sahil ThakorHello, I want to add two support point to have this solution, that is:
If we add the text value even in the success scenario it will save the output in log.html file which can be referred later to see the text that was validated earlier.
Second thing, if empty string is somehow coming in variable and still the step passed (where user actually wanted to validate a non empty text) then users can verify the text and fix the script. (via reading steps chances will increase to spot this if we add text in the step).
The Keyword Wait Until Page Contains has no INFO in the results.
KEYWORD SeleniumLibrary . Wait Until Page Contains ${HOME_PAGE_WELCOME_TEXT} Documentation:Waits until text appears on the current page. Start / End / Elapsed:20250702 10:21:31.793 / 20250702 10:21:31.802 / 00:00:00.009So when a variable like ${HOME_PAGE_WELCOME_TEXT} is used you cannot view the value of the text that should be on the Page.
Adding an INFO line which shows the value of the text that the Page should contain will make it clear to see the value of the text in case of using a variable in the Keyword.