Repository navigation
NPE in AccessTokenRequestParams#addExtraParameters method #1082
Description
The method throw NullPointerException each time that it call when the class variable extraParameters is null because the initialisation is done for the parameter variable and not for the class variable with the same name. The this. is missing.
public AccessTokenRequestParams addExtraParameters(Map<String, String> extraParameters) {
if (extraParameters == null || extraParameters.isEmpty()) {
return this;
}
if (this.extraParameters == null) {
extraParameters = new HashMap<>(); // Error
}
this.extraParameters.putAll(extraParameters);
return this;
}
It should be :
if (this.extraParameters == null) {
this.extraParameters = new HashMap<>();
}
Activity
king-407 commentedon Jun 16, 2026
Hi, I would like to work on this issue.
From what I understand,
AccessTokenRequestParams#addExtraParametersinitializes the method parameter instead of thethis.extraParametersfield when the field is null. Because of that, the followingthis.extraParameters.putAll(...)call can throw aNullPointerException.I can add a focused regression test for this case and then fix the initialization to assign
this.extraParameters = new HashMap<>().Would a contribution in this direction be welcome?