Repository navigation
3.1.1 dropping some dependencies. #251
Description
This is a Bug Report
Description
As of version 3.1.1 certain dependencies seem to be dropped from packaging. Currently seeing this with stateful.co - Not sure if because of full-stop, or something deeper in the package.json.
Generated package.json and resulting node-modules folder below (can produce a minimal example - but pressed for time atm):
less package.json
{
"dependencies": {
"babel-runtime": "^6.26.0",
"aws-xray-lambda-promise-subsegment": "^1.1.0",
"raven": "^2.1.2",
"stateful.co": "^1.0.1"
}
}
ls -1p node_modules
async/
async-listener/
aws-xray-lambda-promise-subsegment/
aws-xray-sdk/
aws-xray-sdk-core/
aws-xray-sdk-express/
aws-xray-sdk-mysql/
aws-xray-sdk-postgres/
babel-runtime/
colors/
continuation-local-storage/
cookie/
core-js/
cycle/
emitter-listener/
eyes/
isstream/
lsmod/
moment/
pkginfo/
raven/
regenerator-runtime/
semver/
shimmer/
stack-trace/
timed-out/
underscore/
winston/
Activity
colinfindlay-nz commentedon Oct 10, 2017
Further info - the generated master package.json
.webpack/dependencies/package.jsoncontains:Can confirm full stops in package names break things - not sure why it wasn't happening in 3.1.0
HyperBrain commentedon Oct 10, 2017
@silver2k Just had a brain flash.... I think I know what it is - The
npm lscommand used to fetch the dependency tree cuts thestdoutas soon as its buffer is full. The default buffer size is 200K, which might be not enough if you have lots of dependencies.There is a hidden setting for the plugin to increase the buffer size.
Can you try to set
custom: packExternalModulesMaxBuffer: 614400(600 KB) and check if it works then? If necessary increase the size further (I do not know if there's a physical limit).HyperBrain commentedon Oct 10, 2017
In case this solves your problem, we should increase the default buffer size.
Regarding the package name parsing (full stops) I do not remember that there was any change, but I'll check it to be sure.
colinfindlay-nz commentedon Oct 10, 2017
See comment above - it's definitely the fullstop in
stateful.cobeing read as a nested dependency, rather than the full name.HyperBrain commentedon Oct 10, 2017
@silver2k Thanks for the clarification. Flagged it as bug.
HyperBrain commentedon Oct 10, 2017
Found the issue in #246 (commented there). I'll provide a fixed release asap.
HyperBrain commentedon Oct 10, 2017
@silver2k Can you try with
"serverless-webpack": "serverless-heaven/serverless-webpack#fix-modules-with-full-stop"if that fixes the problem? As soon as you report back, I'll prepare 3.1.2HyperBrain commentedon Oct 11, 2017
I did a quick check with a test project that includes "stateful.co" and it worked for me with the fix.
colinfindlay-nz commentedon Oct 11, 2017
Can confirm it's now working as expected
HyperBrain commentedon Oct 11, 2017
Released with 3.1.2