Repository navigation
shelljs.find doesn't return contents of a dir on windows #1227
Description
Activity
I spent some time looking at the changes between 0.8.5 and 0.9.0 but don't see any in
find.js, could bels.jsand the swap in glob dependency but don't have my windows machine right now for more testing. Will post here if I find something.It's possible that the glob change affected this. Do you think you would be able to write a unit test (as a PR for the shelljs/shelljs repo) which would assert the correct behavior? If you can do that then I can see if I can change the glob expression to do the right thing on Windows.
Do you think you would be able to write a unit test (as a PR for the shelljs/shelljs repo) which would assert the correct behavior?
sure, will do it tomorrow 👍🏼
Repro: https://github.com/cristiand391/shelljs-find-windows-bug
I put a dummy project dir for testing:
shelljs.findused to return the contents of the dir (recursive read):https://github.com/cristiand391/shelljs-find-windows-bug/blob/db712a1b83e66ed005e78893e7b480d58175f66c/test.js#L5
this works on linux and windows when using shelljs v0.8.5 but fails on windows after updating to v0.9.0 or higher:
CI runs:
✅ v0.8.5 linux
✅ v0.8.5 windows:
https://github.com/cristiand391/shelljs-find-windows-bug/actions/runs/16007671602
✅ v.0.9.0 linux
❌ v0.9.0 windows:
https://github.com/cristiand391/shelljs-find-windows-bug/actions/runs/16007821671
only 1 filepath was returned:
✅ v0.10.0 linux
❌ v0.10.0 windows
https://github.com/cristiand391/shelljs-find-windows-bug/actions/runs/16007701904
only 1 filepath was returned:
