Visitar URL original
Add TypedDict to slack_sdk.models classes · Issue #1515 · slackapi/python-slack-sdk · GitHub
Skip to content

Add TypedDict to slack_sdk.models classes #1515

Open
Open
Add TypedDict to slack_sdk.models classes#1515
Labels
Version: 3xdiscussionM-T: An issue where more input is needed to reach a decisionenhancementM-T: A feature request for new functionalityweb-client
Milestone
4.x

Description

@ya7010
ya7010
opened on Jun 23, 2024

The Client treats Json-format Request Bodies as dict, but can benefit from completion and static analysis if TypedDict is supported.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.rtm (RTM client)
  • slack_sdk.signature (Request Signature Verifier)

Activity

  1. ya7010
    added
    untriaged
    on Jun 23, 2024
  2. seratch
    added
    enhancementM-T: A feature request for new functionality
    discussionM-T: An issue where more input is needed to reach a decision
    web-client
    Version: 3x
    and removed
    untriaged
    on Jun 24, 2024
  3. seratch
    added this to the 4.x milestone on Jun 24, 2024

  4. seratch commented on Jun 24, 2024

    @seratch
    seratch
    on Jun 24, 2024
    Contributor

    Hi @yassun7010, thanks for sharing the idea!

    TypedDict is a relatively new feature introduced in Python 3.8, and this SDK still supports Python 3.6 and 3.7. We know these older versions are already EOLed, but in reality, many apps need a certain amount of time to upgrade to a newer runtime. Therefore, we don't immediately cut support for those versions.

    We may consider dropping support for the old versions starting with the next major release (v4), but we don't plan to bump the major version in the short term. We will keep this issue open as a future enhancement idea. Thanks again for sharing this!

  5. seratch
    changed the title [-]Support TypedDict.[/-] [+]Add TypedDict to slack_sdk.models classes[/+] on Jun 24, 2024

  6. ya7010 commented on Jun 24, 2024

    @ya7010
    ya7010
    on Jun 24, 2024
    Author

    @seratch
    Thanks for explaining the situation.

    Looking forward to the v4 release ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Version: 3xdiscussionM-T: An issue where more input is needed to reach a decisionenhancementM-T: A feature request for new functionalityweb-client

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions