Visitar URL original
`withCompression'` should take a predicate function · Issue #148 · snapframework/snap-core · GitHub
Skip to content

withCompression' should take a predicate function #148

Open

Description

@hvr

The current signature reads:

withCompression' :: MonadSnap m
                 => Set ByteString    -- ^ set of compressible MIME types
                 -> m a               -- ^ the web handler to run
                 -> m ()

The use of Set seems to be too inflexible to me, e.g. if you wanted to compress all mime-types matching text/*, you'd have to enumerate them all; or if you wanted to use a HashSet instead of Set. Also, in some cases you might want to compress the data only if a certain size threshold is exceeded. Thus, I'd suggest using a predicate function with the signature :: ByteString -> Int64 -> Bool instead of a value of type Set ByteString.

PS: is there a reason, that the monadic value of m a is discarded, and is transformed into a m () action?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions