Repository navigation
urllib3 should send http/1.1 ALPN extension by default #1892
Description
Some servers start to require ALPN extension and shut down HTTPS connections forecefully when a client does not indicate HTTP protocol version in ALPN extension. The fix is a trivial one-liner. Daniel told me that curl has been setting ALPN header for years without any negative side-effects.
See https://bugs.python.org/issue40968 for CPython bug
See python/cpython#20959 for CPython PR
Activity
sethmlarson commentedon Jun 18, 2020
Thanks for opening this! I agree we should implement this.
pquentin commentedon Jul 16, 2020
It ended up being a 200 lines fix, as we support PyOpenSSL, SecureTransport, and had to test this. But it's in the master branch now :)
sethmlarson commentedon Jul 16, 2020
I should know better that anything with the
TLSlabel should disqualify theContributor Friendlylabel just based on what we've got going in the TLS department. :)