Visitar URL original
Merge remote-tracking branch 'wesbos/master' · wesbos/JavaScript30@470fad4 · GitHub
Skip to content

Commit 470fad4

Browse files
committed
Merge remote-tracking branch 'wesbos/master'
* wesbos/master: Rename Day2 project name to have the word 'and' instead of the plus (+) sign as this can confuse URLs Add Mike Ekkel to bloglist add Michael Einsohn to readme change append() to appendChild add Adriana Rios to readme 👋 Add link to Ayo Isaiah's recaps and lessons learned add the Chinese description add the chinese guides link you sure did forget it here too lol Added Community section forgot the closing </ul>
2 parents 3b99bc4 + 6f17aa3 commit 470fad4

7 files changed

Lines changed: 30 additions & 5 deletions

File tree

‎18 - Adding Up Times with Reduce/index-FINISHED.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@
180180
<li data-time="4:04">
181181
Video 58
182182
</li>
183-
183+
</ul>
184184
<script>
185185

186186
const timeNodes = Array.from(document.querySelectorAll('[data-time]'));

‎18 - Adding Up Times with Reduce/index-START.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@
180180
<li data-time="4:04">
181181
Video 58
182182
</li>
183-
183+
</ul>
184184
<script>
185185
</script>
186186
</body>

‎22 - Follow Along Link Highlighter/index-FINISHED.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
const triggers = document.querySelectorAll('a');
3030
const highlight = document.createElement('span');
3131
highlight.classList.add('highlight');
32-
document.body.append(highlight);
32+
document.body.appendChild(highlight);
3333

3434
function highlightLink() {
3535
const linkCoords = this.getBoundingClientRect();

‎PULL_REQUEST_TEMPLATE.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
👋👋👋👋👋👋👋👋👋👋👋👋👋👋
2+
👋👋👋Hello Friend!👋👋👋👋
3+
👋👋👋👋👋👋👋👋👋👋👋👋👋👋
4+
5+
Thanks for Submitting a pull request. Before you hit that button please make sure:
6+
7+
These files are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things or fixed a small bug, that is great great, but I will be keeping them the same as the videos to avoid confusing.
8+
9+
Spelling mistakes / CSS updates / other clarifications are welcome as long as they don't change what is shown in the videos.
10+
11+
I encourage you to blog about your implementation and add the link to this repo - that way everyone can benefit from it.
12+
13+

‎readme.md‎

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,21 @@ Starter Files + Completed solutions for the JavaScript 30 Day Challenge.
66

77
Grab the course at [https://JavaScript30.com](https://JavaScript30.com)
88

9-
Text-based guides (unofficial) for the challenges can be found here - [Text Guides](https://github.com/nitishdayal/JavaScript30).
9+
## Community #JavaScript30 Content
1010

11-
## Pull Requests
11+
Feel free to submit a PR adding a link to your own recaps, guides or reviews!
12+
13+
* [Nitish Dayal's Text Guides](https://github.com/nitishdayal/JavaScript30) are great for those who like reading over watching
14+
* [Meredith Underell's](http://blog.meredithunderell.com/tag/javascript30/) Quick Lessons Learned
15+
* [Rowan Weismiller's](http://rowanweismiller.com/blog/javascript-30/) Recaps + Lessons Learned
16+
* [Thorsten Frommen](https://tfrommen.de/tag/javascript-30/) shares how he solved the exercises before viewing the answers
17+
* [Soyaine 写的中文指南](https://github.com/soyaine/JavaScript30)包含了过程记录和难点解释
18+
* [Ayo Isaiah's](https://freshman.tech/archive/#javascript30) Recaps and Lessons Learned
19+
* [Adriana Rios](https://stpcollabr8nlstn.github.io/JavaScript30/) shares her alternative solutions
20+
* [Michael Einsohn](http://30daysofjs.michaeleinsohn.com) publishes each challenge after watching the video once
21+
* [Mike Ekkel](https://medium.com/@mike_ekkel/javascript-30-a-30-day-vanilla-js-challenge-6a733fc9f62c#.9frjtaje9)
22+
23+
## A note on Pull Requests
1224

1325
These are meant to be 1:1 copies of what is done in the video. If you found a better / different way to do things, great, but I will be keeping them the same as the videos.
1426

0 commit comments

Comments
 (0)