Visitar URL original
haskell-src-meta is a heavyweight dependency · Issue #827 · yesodweb/persistent · GitHub
Skip to content

haskell-src-meta is a heavyweight dependency #827

Closed

Description

@snoyberg

Sorry I'm only noticing this a year later, I realize I was pinged on #717. That PR introduced a dependency on haskell-src-meta in order to allow for parsing Haskell expressions. Unfortunately, that library introduces (via itself and dependencies) a relatively heavy compile time cost. I would like to propose that we move the Database.Persist.Sql.Raw.QQ module to a separate package so that users of persistent itself do not need to pay that cost. Any objection? Note that this would be a breaking change.

CC @felixSchl @cdepillabout @paul-rouse (commenters on the PR).

Activity

  1. added a commit that references this issue on Aug 26, 2018
    7c12ad4
  2. added a commit that references this issue on Aug 28, 2018
    d9f10ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions