Upcoming breaking change: Hidden Files will be excluded by default

From September 2nd, 2024, we will no longer include hidden files and folders as part of the default upload of the v3 and v4 upload-artifact actions. This reduces the risk that credentials are accidentally uploaded into artifacts. Customers who need to continue to upload these files can use a new option, ‘include-hidden-files’, to continue to do so.

https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

Enable `include-hidden-files` option for coverage upload

Why introducing breaking changes to v3 and v4 instead of making a new v5 version?

      - name: Upload Docker Compose Files Artifact
        id: upload_docker_compose_files
        uses: actions/upload-artifact@v4.4.0
        include-hidden-files: true
        with:
          name: docker-compose-files
          path: |
            .env
            docker-compose.yaml

I've edited my workflow like above and getting the error:

The workflow is not valid. In .github/workflows/kondukto-package-build-manual.yml (Line: 318, Col: 11): Error from called workflow kondukto-io/kondukto-build/.github/workflows/docker_compose_package.yml@c343cea5db32d5d329cfe25ea5f7f84a88ecb64a (Line: 38, Col: 9): Unexpected value 'include-hidden-files'

I tried both versions v4 and v4.4.0

I've edited my workflow like above and getting the error:

You should place include-hidden-files: true under with: block

Thanks a lot. My bad.

Use a non-hidden filename for coverage files

Funny thing [in](include-hidden-files: true) doesn't work on v3, in one screenshoot I point directly to file and also doing a cat to see if it exists and exists

This change resulted in deployment failures for us because we no longer included the full set of files in our deployment artifact.

This also resulted in a lot of CI failures for us... Would be nice if there was at least a warning before rolling breaking changes 🤷‍♂️

Here's how we were calling this action:

    - uses: actions/upload-artifact@v4
      with:
        name: artifacts-${{ strategy.job-index }}
        path: |-
          coverage/.resultset.json
          tests/junit.xml

Funny thing [in](include-hidden-files: true) doesn't work on v3, in one screenshoot I point directly to file and also doing a cat to see if it exists and exists

👋 Thanks for the report, we're rolling back the v3 and v3-node20 updates while we work on fixing that issue.

Use a non-hidden filename for coverage files

@nebuk89

@nebuk89 can we send you the invoice for downtime and time spent because this didn't break the pipeline but instead deployed applications without needed files to run..

Acknowledge your mistake and don't hide behind the shield that you somehow saved the day by shielding us from the big bad evil hidden files upload... Seriously, go touch grass.. this is not some zero-day you're patching, you do not ignore semver and push a breaking change for such a stupid reason.

Why not publish a v5 version for this? This is breaking a ton of our things that build files with .folders such as Azure Functions.

We still use v3 of upload-artifacts. My scheduled pipelines broke last night silently because it was looking for our .env files but needed include-hidden-files to be set to true instead of the default false that was supposed to be a breaking change for v4.

Fix actions/upload-artifact#602

Unbreak workflows

Update tests.yml

upload-artifacts: include hidden benchmarks results

Note to self: actions can just break

🤦 fix workflows

Update release.yml

Update upgrade-main.yml

Fix CI coverage collection

Update tests.yml

Navigation Menu

Repository navigation

Upcoming breaking change: Hidden Files will be excluded by default #602

66 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Upcoming breaking change: Hidden Files will be excluded by default #602

Description

Activity

dolfinus commented on Sep 2, 2024

umrkt commented on Sep 2, 2024

dolfinus commented on Sep 2, 2024

umrkt commented on Sep 2, 2024

catYalere commented on Sep 2, 2024

buckett commented on Sep 2, 2024

Drowze commented on Sep 2, 2024

joshmgross commented on Sep 2, 2024

66 remaining items

Pixelatex commented on Sep 3, 2024

smokedlinq commented on Sep 3, 2024

josheche commented on Sep 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions