Visitar URL original
Warn when `UV_CACHE_DIR` has changed by jamesbraza · Pull Request #601 · astral-sh/setup-uv · GitHub
Skip to content

Warn when UV_CACHE_DIR has changed - #601

Merged
eifinger merged 6 commits into
astral-sh:mainfrom
jamesbraza:fixing-teardown-message
Oct 2, 2025
Merged

Warn when UV_CACHE_DIR has changed#601
eifinger merged 6 commits into
astral-sh:mainfrom
jamesbraza:fixing-teardown-message

Conversation

@jamesbraza

@jamesbraza jamesbraza commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Closes #592

@jamesbraza
jamesbraza requested a review from eifinger as a code owner October 1, 2025 16:23
eifinger
eifinger requested changes Oct 1, 2025
View reviewed changes

@eifinger eifinger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We don't need the "unset" case though

Comment thread src/save-cache.ts Outdated
@jamesbraza
jamesbraza requested a review from eifinger October 1, 2025 19:52
eifinger
eifinger reviewed Oct 2, 2025
View reviewed changes
Comment thread src/save-cache.ts Outdated
eifinger
eifinger requested changes Oct 2, 2025
View reviewed changes

@eifinger eifinger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the extra comments.

Please run npm run all to regenerate the distfolder. Otherwise CI will fail.

Comment thread src/save-cache.ts Outdated
@eifinger eifinger changed the title Updated saveCache to give better error message when UV_CACHE_DIR has changed Warn when UV_CACHE_DIR has changed Oct 2, 2025
eifinger
eifinger approved these changes Oct 2, 2025
View reviewed changes

@eifinger eifinger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eifinger
eifinger merged commit f9c6974 into astral-sh:main Oct 2, 2025
76 checks passed
@jamesbraza
jamesbraza deleted the fixing-teardown-message branch October 2, 2025 17:05
@github-actions github-actions Bot mentioned this pull request Apr 3, 2026
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eifinger eifinger eifinger approved these changes

Assignees

No one assigned

Labels

bugfix hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weird Cache path /home/runner/work/_temp/setup-uv-cache does not exist on disk after uv sync

2 participants

@jamesbraza @eifinger