Visitar URL original
Check remote wheel metadata prefetch ranges by astral-automations-bot[bot] · Pull Request #21919 · astral-sh/uv · GitHub
Skip to content

Check remote wheel metadata prefetch ranges - #21919

Merged
zanieb merged 1 commit into
mainfrom
zb/check-remote-metadata-prefetch
Sep 22, 2026
Merged

zanieb merged 1 commit into
mainfrom
zb/check-remote-metadata-prefetch

Conversation

@astral-automations-bot

Copy link
Copy Markdown
Contributor

wheel_metadata_from_remote_zip can panic in debug builds while computing a prefetch range from a malformed ZIP64 size, before the ZIP reader validates the entry. Use checked arithmetic and omit an unrepresentable optional prefetch, leaving the existing entry-range validation and normal ranges unchanged. Follows up on #18605.

@codspeed

codspeed Bot commented Sep 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 5.31%

❌ 1 regressed benchmark
✅ 40 untouched benchmarks
⏩ 12 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation install_wheel_many_files 57.1 ms 60.3 ms -5.31%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing zb/check-remote-metadata-prefetch (38b03b7) with main (8460ef5)

Open in CodSpeed

Footnotes

  1. 12 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@astral-sh-bot

astral-sh-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown

uv test inventory changes

This PR changes the tests when compared with the main base revision.

  • Added tests: 1
  • Removed tests: 0
  • Changed suites: 1
uv-client::it: +1 / -0

Added:

  • uv-client::it::remote_metadata::remote_metadata_rejects_overflowing_zip64_size

Removed: none

@zanieb
zanieb merged commit 9937fa2 into main Sep 22, 2026
62 of 63 checks passed
@zanieb
zanieb deleted the zb/check-remote-metadata-prefetch branch September 22, 2026 21:09
@zanieb zanieb added the project:maintainer-followups Maintainer follow-up work label Oct 9, 2026

This branch was successfully deployed

1 active deployment
automations — 38b03b74 Deployed Sep 22, 2026 by astral-automations-bot[bot] via review / security review #47392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working project:maintainer-followups Maintainer follow-up work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants