Visitar URL original
Use Cargo warning policy for Clippy by charliermarsh · Pull Request #22122 · astral-sh/uv · GitHub
Skip to content

Use Cargo warning policy for Clippy - #22122

Merged
charliermarsh merged 1 commit into
charlie/uv-rust-1.99from
charlie/uv-rust-1.97-features
Oct 1, 2026
Merged

charliermarsh merged 1 commit into
charlie/uv-rust-1.99from
charlie/uv-rust-1.97-features

Conversation

@charliermarsh

@charliermarsh charliermarsh commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Use Rust 1.97's Cargo warning policy for all three Clippy jobs and the documented local Clippy commands. CARGO_BUILD_WARNINGS=deny rejects warnings, including cached diagnostics, without changing compiler flags or invalidating the build cache.

Stacked on #22121, which raises the MSRV to 1.97 and updates the trampoline nightly.

@charliermarsh
charliermarsh marked this pull request as draft October 1, 2026 14:27
@charliermarsh
charliermarsh marked this pull request as ready for review October 1, 2026 14:28
@charliermarsh
charliermarsh added this pull request to stack #22123 October 1, 2026 14:31
@charliermarsh
charliermarsh marked this pull request as draft October 1, 2026 14:42
@charliermarsh
charliermarsh marked this pull request as ready for review October 1, 2026 14:45
@charliermarsh
charliermarsh marked this pull request as draft October 1, 2026 14:51
@charliermarsh
charliermarsh force-pushed the charlie/uv-rust-1.97-features branch from 0060205 to 0a28989 Compare October 1, 2026 14:52
@codspeed

codspeed Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Merging this PR will improve performance by 6.76%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 52 untouched benchmarks
⏩ 47 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation from_hex/lowercase[32] 385.8 µs 361.3 µs +6.76%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing charlie/uv-rust-1.97-features (0a28989) with charlie/uv-rust-1.99 (edd214a)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on charlie/uv-rust-1.99 (af25015) during the generation of this report, so f0f0415 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@charliermarsh
charliermarsh force-pushed the charlie/uv-rust-1.97-features branch from 0a28989 to 31267ab Compare October 1, 2026 16:38
@charliermarsh
charliermarsh force-pushed the charlie/uv-rust-1.97-features branch from 31267ab to 1b51660 Compare October 1, 2026 17:26
charliermarsh added a commit to astral-sh/ruff that referenced this pull request Oct 1, 2026
## Summary

- Use the integer bit APIs stabilized in Rust 1.97 for packed node
indices, token capacity, rule iteration, and type-variable support sets.
- Use Cargo's warning policy in our native and WASM Clippy checks,
keeping warnings fatal without changing compiler flags and invalidating
the build cache. Update the contributing guides to match.

Preserves the Rust 1.97 MSRV. The warning policy change follows
astral-sh/uv#22122.
@charliermarsh
charliermarsh force-pushed the charlie/uv-rust-1.97-features branch from 1b51660 to f4f7963 Compare October 1, 2026 18:09
@charliermarsh charliermarsh added the internal A refactor or improvement that is not user-facing label Oct 1, 2026
@charliermarsh
charliermarsh marked this pull request as ready for review October 1, 2026 18:46
@charliermarsh
charliermarsh merged commit cbf6106 into main Oct 1, 2026
67 checks passed
@charliermarsh
charliermarsh deleted the charlie/uv-rust-1.97-features branch October 1, 2026 18:47

This branch was successfully deployed

1 active deployment
automations — f4f79634 Deployed Oct 1, 2026 by charliermarsh via review / security review #48854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant