Finalize records before exporting

@tonistiigi

follow-up docker/actions-toolkit#652 (comment)

We should make sure records are finalized before exporting them similar to history trace:

Lines 57 to 70 in 9ba3f77

    
           // build is complete but no trace yet. try to finalize the trace 
        
           time.Sleep(1 * time.Second) // give some extra time for last parts of trace to be written 
        
           c, err := rec.node.Driver.Client(ctx) 
        
           if err != nil { 
        
           	return "", nil, err 
        
           } 
        
           _, err = c.ControlClient().UpdateBuildHistory(ctx, &controlapi.UpdateBuildHistoryRequest{ 
        
           	Ref:      rec.Ref, 
        
           	Finalize: true, 
        
           }) 
        
           if err != nil { 
        
           	return "", nil, err 
        
           }

@tonistiigi I wonder if we should have a Finalize attribute in

buildx/commands/history/utils.go

Lines 116 to 119 in 9ba3f77

    
           type queryOptions struct { 
        
           	CompletedOnly bool 
        
           	Filters       []string 
        
           }

To share logic for both export and trace in queryRecords?

Navigation Menu

Repository navigation

Finalize records before exporting #3149

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// build is complete but no trace yet. try to finalize the trace
	time.Sleep(1 * time.Second) // give some extra time for last parts of trace to be written

	c, err := rec.node.Driver.Client(ctx)
	if err != nil {
	return "", nil, err
	}
	_, err = c.ControlClient().UpdateBuildHistory(ctx, &controlapi.UpdateBuildHistoryRequest{
	Ref: rec.Ref,
	Finalize: true,
	})
	if err != nil {
	return "", nil, err
	}

	type queryOptions struct {
	CompletedOnly bool
	Filters []string
	}

Finalize records before exporting #3149

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions