Repository navigation
Free-threading tests - #1136
Merged
Merged
Free-threading tests#1136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the whole test suite with pytest-run-parallel.
is thread safe as long as multiple calls don't share the same objects; and that
SentencePieceProcessor.Normalize()- is safe even while sharing the sameSentencePieceProcessorobject (this is because pytest-run-parallel does not parallelisesetUp, so all threads use the same shared state).Notable exclusion is the
logstream=parameter, which is NOT thread safe. However it is undocumented and untested, which makes it fall out of scope of this PR.Note how the stress testing performed by pytest-run-parallel is stochastic, and that on 4 threads it is unlikely to catch the more uncommon race conditions. However, I've extensively ran it on 32 threads locally and did not incur in any failures.