Visitar URL original
feat: Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected by agrawalradhika-cell · Pull Request #1859 · googleapis/google-auth-library-python · GitHub
Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected - #1859

Merged
agrawalradhika-cell merged 6 commits into
googleapis:mainfrom
agrawalradhika-cell:public-method-for-mtls-update
Nov 5, 2025
Merged

feat: Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected#1859
agrawalradhika-cell merged 6 commits into
googleapis:mainfrom
agrawalradhika-cell:public-method-for-mtls-update

Conversation

@agrawalradhika-cell

@agrawalradhika-cell agrawalradhika-cell commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Add public wrapper for check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected. Also, fix check_use_client_cert to return boolean value.

Change #1848 added the check_use_client_cert method that helps know if client cert should be used for mTLS connection. However, that was in a private class, thus, created a public wrapper of the same function so that it can be used by python Client Libraries. Also, updated check_use_client_cert to return a boolean value instead of existing string value for better readability and future scope.

@agrawalradhika-cell
feat: Add public wrapper for use_client_Cert function
fb37ed0 
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
@agrawalradhika-cell
fix: update lint fixes
39bff9b 
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
@agrawalradhika-cell agrawalradhika-cell changed the title Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected feat: Add public wrapper for _mtls_helper.check_use_client_cert which enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the MWID/X.509 cert sources detected Nov 4, 2025
@agrawalradhika-cell
agrawalradhika-cell marked this pull request as ready for review November 4, 2025 22:40
@agrawalradhika-cell
agrawalradhika-cell requested review from a team November 4, 2025 22:40
daniel-sanche
daniel-sanche reviewed Nov 4, 2025
View reviewed changes
Comment thread google/auth/transport/_mtls_helper.py Resolved
Comment thread google/auth/transport/_mtls_helper.py Resolved
Comment thread google/auth/transport/_mtls_helper.py Resolved
Comment thread google/auth/transport/grpc.py Resolved
Comment thread google/auth/transport/mtls.py Resolved
Comment thread tests/transport/test__mtls_helper.py Resolved
@nbayati nbayati added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2025
@agrawalradhika-cell
fix: Fix docstrings and minor nits
ff1de0a 
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
@agrawalradhika-cell
fix: check update in _mtls_helper
8fa9fb6 
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
nbayati
nbayati reviewed Nov 5, 2025
View reviewed changes

@nbayati nbayati left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, I just have a minor suggestion: Add a test case to verify the behavior when GOOGLE_API_USE_CLIENT_CERTIFICATE is set to a string other than "true" or "false". The current implementation correctly evaluates such cases to False, and adding an explicit test for this would make the test suite more comprehensive.

daniel-sanche
daniel-sanche previously approved these changes Nov 5, 2025
View reviewed changes

@daniel-sanche daniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but one more small comment

Comment thread google/auth/transport/_mtls_helper.py Resolved
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@agrawalradhika-cell
chore: Add unit test for specific case and improve docstring
cf6df54 
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
@nbayati nbayati added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@andyrzhao andyrzhao added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@andyrzhao
andyrzhao self-requested a review November 5, 2025 06:30
andyrzhao
andyrzhao approved these changes Nov 5, 2025
View reviewed changes

@andyrzhao andyrzhao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for working on this!

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 5, 2025
@agrawalradhika-cell
agrawalradhika-cell merged commit 1535ecc into googleapis:main Nov 5, 2025
8 checks passed
This was referenced Nov 5, 2025
Closed
Merged
Linchin added a commit that referenced this pull request Nov 5, 2025
@Linchin
chore: librarian release pull request: 20251105T230735Z (#1863)
89a8838 
Librarian Version: v0.5.0
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator:latest
<details><summary>google-auth: 2.43.0</summary>

##
[2.43.0](v2.42.1...v2.43.0)
(2025-11-05)

### Features

* Add public wrapper for _mtls_helper.check_use_client_cert which
enables mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, when the
MWID/X.509 cert sources detected (#1859)
([1535ecc](1535eccb))

* Enable mTLS if GOOGLE_API_USE_CLIENT_CERTIFICATE is not set, if the
MWID/X.509 cert sources detected (#1848)
([395e405](395e405b))

* onboard `google-auth` to librarian (#1838)
([c503eaa](c503eaa5))

</details>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers
@daniel-sanche daniel-sanche daniel-sanche approved these changes
@andyrzhao andyrzhao andyrzhao approved these changes
@yaoliugg yaoliugg yaoliugg approved these changes
@nbayati nbayati nbayati approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agrawalradhika-cell @daniel-sanche @andyrzhao @yaoliugg @nbayati @yoshi-kokoro