Visitar URL original
Fix false warning about unstable graph by octylFractal · Pull Request #39479 · gradle/gradle · GitHub
Skip to content

Fix false warning about unstable graph - #39479

Merged
jvandort merged 2 commits into
releasefrom
ot/fix/unstable-graph-on-selector-release
Oct 18, 2026
Merged

Fix false warning about unstable graph#39479
jvandort merged 2 commits into
releasefrom
ot/fix/unstable-graph-on-selector-release

Conversation

@octylFractal

@octylFractal octylFractal commented Oct 16, 2026

Copy link
Copy Markdown
Member

Fixes #39454

This is really only a temporary fix, as we still go through a path that we want to fix eventually.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@octylFractal
Fix false warning about unstable graph
6e836fd 
Fixes #39454

This is really only a temporary fix, as we still go through a path that
we want to throw in.
@octylFractal
octylFractal requested a review from jvandort October 16, 2026 11:19
@octylFractal octylFractal self-assigned this Oct 16, 2026
@octylFractal
octylFractal requested a review from a team as a code owner October 16, 2026 11:19
@octylFractal octylFractal added a:regression This used to work in:dependency-resolution engine metadata labels Oct 16, 2026
@jvandort
Clarify selector reuse comments in SelectorState
3601d4f 
Reword the unstable-graph TODO in markForReuse() to state that forced
virtual platform alignment relies on this branch to converge, and what
must change before it can fail the resolution instead.
@ljacomet ljacomet added this to the 9.8.2 milestone Oct 18, 2026
@jvandort
jvandort changed the base branch from master to release October 18, 2026 13:27
@jvandort
jvandort added this pull request to the merge queue Oct 18, 2026
@bot-gradle

bot-gradle commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

WARN: The milestone of this PR is 9.8.2, but the version is 9.8.1

Merged via the queue into release with commit 688c0c1 Oct 18, 2026
23 of 25 checks passed
@jvandort
jvandort deleted the ot/fix/unstable-graph-on-selector-release branch October 18, 2026 16:05
@github-actions github-actions Bot mentioned this pull request Oct 18, 2026
Closed
blindpirate added a commit that referenced this pull request Oct 19, 2026
@blindpirate
Drop removed virtualConfiguration fixture call
4a09b0e 
The test added on release by #39479 uses
ResolveTestFixture.virtualConfiguration(), which master removed in
e10f35a. Virtual platform nodes no longer need to be declared, so
the call is dropped like the other migrated call sites.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvandort jvandort jvandort approved these changes

Assignees

@octylFractal octylFractal

Labels

a:regression This used to work in:dependency-resolution engine metadata

Projects

None yet

Milestone

9.8.2

Development

Successfully merging this pull request may close these issues.

Gradle 9.8 reports a false "graph wasn't stable enough" warning when aligning versions with a virtual platform

4 participants

@octylFractal @bot-gradle @jvandort @ljacomet