Visitar URL original
Fix minor issues not covered by PR #9137 by mswierq · Pull Request #9147 · grpc/grpc-go · GitHub
Skip to content

Fix minor issues not covered by PR #9137 - #9147

Merged
easwars merged 2 commits into
grpc:masterfrom
mswierq:fix/8693-minor-fixes-follow-up
Jun 5, 2026
Merged

Fix minor issues not covered by PR #9137#9147
easwars merged 2 commits into
grpc:masterfrom
mswierq:fix/8693-minor-fixes-follow-up

Conversation

@mswierq

@mswierq mswierq commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR is a follow up of already merged PR #9137

Delivers minor fixes for nit comments unaddressed in the previous PR

RELEASE NOTES: N/A

@codecov

codecov Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.11%. Comparing base (b58f32d) to head (471ce2f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9147      +/-   ##
==========================================
- Coverage   83.18%   83.11%   -0.07%     
==========================================
  Files         418      418              
  Lines       33709    33710       +1     
==========================================
- Hits        28041    28019      -22     
- Misses       4248     4264      +16     
- Partials     1420     1427       +7
Files with missing lines Coverage Δ
balancer/rls/control_channel.go 83.33% <100.00%> (+0.20%) ⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mswierq mswierq mentioned this pull request May 28, 2026
Merged
@easwars
easwars self-requested a review June 3, 2026 03:31
@easwars easwars self-assigned this Jun 3, 2026
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jun 3, 2026
@easwars easwars added this to the 1.82 Release milestone Jun 3, 2026
@mbissa mbissa modified the milestones: 1.82 Release, 1.83 Release Jun 5, 2026
@easwars
easwars merged commit 0f3086d into grpc:master Jun 5, 2026
16 of 19 checks passed
goingforstudying-ctrl added a commit to goingforstudying-ctrl/grpc-go that referenced this pull request Jun 21, 2026
@goingforstudying-ctrl
Fix minor issues not covered by PR grpc#9137 (grpc#9147)
e2e511f 
This PR is a follow up of already merged PR grpc#9137

Delivers minor fixes for nit comments unaddressed in the previous PR

RELEASE NOTES: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@easwars easwars easwars approved these changes

Assignees

@easwars easwars

Labels

Type: Internal Cleanup Refactors, etc

Projects

None yet

Milestone

1.83 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@mswierq @easwars @mbissa