Visitar URL original
Cherry-pick recent changes from master by easwars · Pull Request #9240 · grpc/grpc-go · GitHub
Skip to content

Cherry-pick recent changes from master - #9240

Merged
easwars merged 2 commits into
grpc:v1.83.xfrom
easwars:v1.83.x
Jul 21, 2026
Merged

easwars merged 2 commits into
grpc:v1.83.xfrom
easwars:v1.83.x

Conversation

@easwars

@easwars easwars commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

RELEASE NOTES:

  • server: Stop reading from the connection when flooded by HTTP/2 frames. The default value for this limit is 100 frames, excluding DATA and HEADERS, and may be changed by setting environment variable GRPC_GO_EXPERIMENTAL_CONTROL_BUFFER_THROTTLE_LIMIT.
  • xds/rbac: Support Metadata and RequestedServerName permissions matcher fields. If present in a DENY rule, previously these would be ignored and fail-open.
  • xds/rbac: Fix panic when parsing unsupported fields in NotRule/NotId permissions.
  • xds/rbac: Support the deprecated source_ip principal identifier by treating it as equivalent to direct_remote_ip.

easwars added 2 commits July 16, 2026 00:24
See individual commits for details.

Commit #1
=========

transport: Enforce overall limit on controlBuffer size

This change introduces an overall limit on the number of items in the
controlBuffer. Once this limit is reached, reading from the wire is
stopped to give the transport enough time to process items in the
controlBuffer.

HEADERS and DATA frames don't count towards the throttling limit.

Earlier, throttling was only applied to frames that were considered to
result in control frames being written on the transport. But this was
found insufficient in some cases involving RapidReset and MadeYouReset.

Other changes:
* Split the client and server headers into separate structs
* Increase the throttling limit to 100 (since more items are being
  throttled now)

Commit #2
=========

xds/rbac: Fix multiple deviations in implementation from A41 spec

Summary of changes:
* Handle Metadata and RequestedServerName permissions.
* Fix panic in xDS RBAC engine when parsing unsupported fields in
  NotRule/NotId permissions in matchers.go.
* Support the deprecated `source_ip` principal identifier by
  treating it as equivalent to `direct_remote_ip`.
@easwars
easwars requested a review from mbissa July 16, 2026 00:27
@easwars easwars added the Type: Security A bug or other problem affecting security label Jul 16, 2026
@easwars easwars added this to the 1.83 Release milestone Jul 16, 2026
@mbissa mbissa assigned easwars and unassigned mbissa Jul 21, 2026
@easwars
easwars merged commit e393849 into grpc:v1.83.x Jul 21, 2026
12 of 14 checks passed
@easwars
easwars deleted the v1.83.x branch July 21, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Security A bug or other problem affecting security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants