Visitar URL original
chore(pkg): enable perfsprint linter · helm/helm@1d2d63c · GitHub
Skip to content

Commit 1d2d63c

Browse files
mmorel-35mmorel-35
committed
chore(pkg): enable perfsprint linter
#### Description enable perfsprint linter in pkg/cmd Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
1 parent bd33484 commit 1d2d63c

10 files changed

Lines changed: 21 additions & 22 deletions

File tree

‎pkg/action/uninstall_test.go‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package action
1919
import (
2020
"context"
2121
"errors"
22-
"fmt"
2322
"io"
2423
"testing"
2524

@@ -115,7 +114,7 @@ func TestUninstallRelease_Wait(t *testing.T) {
115114
}`
116115
require.NoError(t, unAction.cfg.Releases.Create(rel))
117116
failer := unAction.cfg.KubeClient.(*kubefake.FailingKubeClient)
118-
failer.WaitForDeleteError = fmt.Errorf("U timed out")
117+
failer.WaitForDeleteError = errors.New("U timed out")
119118
unAction.cfg.KubeClient = failer
120119
resi, err := unAction.Run(rel.Name)
121120
is.Error(err)
@@ -149,7 +148,7 @@ func TestUninstallRelease_Cascade(t *testing.T) {
149148
}`
150149
require.NoError(t, unAction.cfg.Releases.Create(rel))
151150
failer := unAction.cfg.KubeClient.(*kubefake.FailingKubeClient)
152-
failer.DeleteError = fmt.Errorf("Uninstall with cascade failed")
151+
failer.DeleteError = errors.New("Uninstall with cascade failed")
153152
failer.BuildDummy = true
154153
unAction.cfg.KubeClient = failer
155154
_, err := unAction.Run(rel.Name)

‎pkg/chart/common/capabilities.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ func newCapabilities(kubeVersionMajor, kubeVersionMinor uint64) (*Capabilities,
173173
KubeVersion: KubeVersion{
174174
Version: version,
175175
normalizedVersion: version,
176-
Major: fmt.Sprintf("%d", kubeVersionMajor),
177-
Minor: fmt.Sprintf("%d", kubeVersionMinor),
176+
Major: strconv.FormatUint(kubeVersionMajor, 10),
177+
Minor: strconv.FormatUint(kubeVersionMinor, 10),
178178
},
179179
APIVersions: DefaultVersionSet,
180180
HelmVersion: helmversion.Get(),

‎pkg/chart/v2/lint/rules/crds.go‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ package rules
1919
import (
2020
"bytes"
2121
"errors"
22-
"fmt"
2322
"io"
2423
"io/fs"
2524
"os"
@@ -102,14 +101,14 @@ func validateCrdsDir(crdsPath string) error {
102101

103102
func validateCrdAPIVersion(obj *k8sYamlStruct) error {
104103
if !strings.HasPrefix(obj.APIVersion, "apiextensions.k8s.io") {
105-
return fmt.Errorf("apiVersion is not in 'apiextensions.k8s.io'")
104+
return errors.New("apiVersion is not in 'apiextensions.k8s.io'")
106105
}
107106
return nil
108107
}
109108

110109
func validateCrdKind(obj *k8sYamlStruct) error {
111110
if obj.Kind != "CustomResourceDefinition" {
112-
return fmt.Errorf("object kind is not 'CustomResourceDefinition'")
111+
return errors.New("object kind is not 'CustomResourceDefinition'")
113112
}
114113
return nil
115114
}

‎pkg/chart/v2/util/save_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ import (
2121
"bytes"
2222
"compress/gzip"
2323
"crypto/sha256"
24+
"encoding/hex"
2425
"errors"
25-
"fmt"
2626
"io"
2727
"os"
2828
"path"
@@ -357,5 +357,5 @@ func sha256Sum(filePath string) (string, error) {
357357
return "", err
358358
}
359359

360-
return fmt.Sprintf("%x", h.Sum(nil)), nil
360+
return hex.EncodeToString(h.Sum(nil)), nil
361361
}

‎pkg/cmd/plugin_verify.go‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ limitations under the License.
1616
package cmd
1717

1818
import (
19+
"errors"
1920
"fmt"
2021
"io"
2122
"os"
@@ -75,12 +76,12 @@ func (o *pluginVerifyOptions) run(out io.Writer) error {
7576

7677
// Only support tarball verification
7778
if fi.IsDir() {
78-
return fmt.Errorf("directory verification not supported - only plugin tarballs can be verified")
79+
return errors.New("directory verification not supported - only plugin tarballs can be verified")
7980
}
8081

8182
// Verify it's a tarball
8283
if !plugin.IsTarball(o.pluginPath) {
83-
return fmt.Errorf("plugin file must be a gzipped tarball (.tar.gz or .tgz)")
84+
return errors.New("plugin file must be a gzipped tarball (.tar.gz or .tgz)")
8485
}
8586

8687
// Look for provenance file

‎pkg/cmd/status.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ func (s statusPrinter) WriteTable(out io.Writer) error {
197197
}
198198
_, _ = fmt.Fprintf(out, "TEST SUITE: %s\n%s\n%s\n%s\n",
199199
h.Name,
200-
fmt.Sprintf("Last Started: %s", h.LastRun.StartedAt.Format(time.ANSIC)),
201-
fmt.Sprintf("Last Completed: %s", h.LastRun.CompletedAt.Format(time.ANSIC)),
200+
"Last Started: "+h.LastRun.StartedAt.Format(time.ANSIC),
201+
"Last Completed: "+h.LastRun.CompletedAt.Format(time.ANSIC),
202202
fmt.Sprintf("Phase: %s", h.LastRun.Phase),
203203
)
204204
}

‎pkg/kube/wait_test.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ limitations under the License.
1717
package kube
1818

1919
import (
20-
"fmt"
20+
"errors"
2121
"net/http"
2222
"strings"
2323
"testing"
@@ -451,7 +451,7 @@ func TestLegacyWaiter_isRetryableError(t *testing.T) {
451451
},
452452
{
453453
name: "non-status error",
454-
err: fmt.Errorf("some generic error"),
454+
err: errors.New("some generic error"),
455455
wantRetry: true,
456456
},
457457
}

‎pkg/release/v1/mock.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ limitations under the License.
1717
package v1
1818

1919
import (
20-
"fmt"
2120
"math/rand"
21+
"strconv"
2222
"time"
2323

2424
"helm.sh/helm/v4/pkg/chart/common"
@@ -57,7 +57,7 @@ func Mock(opts *MockReleaseOptions) *Release {
5757

5858
name := opts.Name
5959
if name == "" {
60-
name = "testrelease-" + fmt.Sprint(rand.Intn(100))
60+
name = "testrelease-" + strconv.Itoa(rand.Intn(100))
6161
}
6262

6363
version := 1

‎pkg/storage/driver/cfgmaps.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func (cfgmaps *ConfigMaps) Create(key string, rls release.Releaser) error {
171171

172172
lbs.init()
173173
lbs.fromMap(rac.Labels())
174-
lbs.set("createdAt", fmt.Sprintf("%v", time.Now().Unix()))
174+
lbs.set("createdAt", strconv.FormatInt(time.Now().Unix(), 10))
175175

176176
rel, err := releaserToV1Release(rls)
177177
if err != nil {
@@ -209,7 +209,7 @@ func (cfgmaps *ConfigMaps) Update(key string, rel release.Releaser) error {
209209

210210
lbs.init()
211211
lbs.fromMap(rls.Labels)
212-
lbs.set("modifiedAt", fmt.Sprintf("%v", time.Now().Unix()))
212+
lbs.set("modifiedAt", strconv.FormatInt(time.Now().Unix(), 10))
213213

214214
// create a new configmap object to hold the release
215215
obj, err := newConfigMapsObject(key, rls, lbs)

‎pkg/storage/driver/secrets.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ func (secrets *Secrets) Create(key string, rel release.Releaser) error {
171171

172172
lbs.init()
173173
lbs.fromMap(rls.Labels)
174-
lbs.set("createdAt", fmt.Sprintf("%v", time.Now().Unix()))
174+
lbs.set("createdAt", strconv.FormatInt(time.Now().Unix(), 10))
175175

176176
// create a new secret to hold the release
177177
obj, err := newSecretsObject(key, rls, lbs)
@@ -202,7 +202,7 @@ func (secrets *Secrets) Update(key string, rel release.Releaser) error {
202202

203203
lbs.init()
204204
lbs.fromMap(rls.Labels)
205-
lbs.set("modifiedAt", fmt.Sprintf("%v", time.Now().Unix()))
205+
lbs.set("modifiedAt", strconv.FormatInt(time.Now().Unix(), 10))
206206

207207
// create a new secret object to hold the release
208208
obj, err := newSecretsObject(key, rls, lbs)

0 commit comments

Comments
 (0)