Visitar URL original
Add filter for bytecode generated by Compose Kotlin compiler plugin by Godin · Pull Request #1616 · jacoco/jacoco · GitHub
Skip to content

Add filter for bytecode generated by Compose Kotlin compiler plugin - #1616

Merged
Godin merged 3 commits into
jacoco:masterfrom
Godin:filter_kotlin_compose
May 4, 2024
Merged

Add filter for bytecode generated by Compose Kotlin compiler plugin#1616
Godin merged 3 commits into
jacoco:masterfrom
Godin:filter_kotlin_compose

Conversation

@Godin

@Godin Godin commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

There is no validation test because there is no official way to use Kotlin Compose Compiler Plugin from Maven.

However here is example.zip for which execution of

./gradlew build jacocoTestReport

before this change produces

before1 before2

and with this change installed into local Maven repository produces

after1 after2

Also, I propose to create a repository based on this example with Cl build that will act as a validation test.

Fixes #1208
Closes #1259

@Godin
Godin force-pushed the filter_kotlin_compose branch from 8b0a9fc to d994109 Compare May 3, 2024 00:01
@Godin Godin self-assigned this May 3, 2024
@Godin Godin added this to the 0.8.13 milestone May 3, 2024
@Godin
Godin force-pushed the filter_kotlin_compose branch from d994109 to c1c7d58 Compare May 3, 2024 00:05
@Godin Godin added the language: Kotlin Tickets about Kotlin language support label May 3, 2024
@Godin Godin changed the title Add filter for bytecode generated by Compose Kotlin Compiler Plugin Add filter for bytecode generated by Compose Kotlin compiler plugin May 3, 2024
@Godin
Godin force-pushed the filter_kotlin_compose branch from c1c7d58 to 287986c Compare May 3, 2024 07:50
@Godin
Godin marked this pull request as ready for review May 3, 2024 18:38
@Godin
Godin requested a review from marchof May 3, 2024 18:38
marchof
marchof requested changes May 4, 2024
View reviewed changes

@marchof marchof left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two compiler warnings in the unit test on modern JDKs that could be fixed.

Comment thread org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/KotlinComposeFilterTest.java Resolved
Comment thread org.jacoco.core.test/src/org/jacoco/core/internal/analysis/filter/KotlinComposeFilterTest.java Resolved
@Godin @marchof
Apply suggestions from code review
5921431 
Co-authored-by: Marc R. Hoffmann <hoffmann@mountainminds.com>
@marchof

marchof commented May 4, 2024

Copy link
Copy Markdown
Member

Looks like the Azure pipeline had a network failure:

Caused by: org.apache.maven.wagon.TransferFailedException: GET request of: org/codehaus/plexus/plexus-utils/3.5.1/plexus-utils-3.5.1.jar from central failed
    at org.apache.maven.wagon.AbstractWagon.getTransfer (AbstractWagon.java:413)

@Godin
Godin enabled auto-merge (squash) May 4, 2024 10:13
@Godin
Godin merged commit 7ab41d1 into jacoco:master May 4, 2024
@Godin
Godin deleted the filter_kotlin_compose branch May 4, 2024 10:17
@Godin

Godin commented May 4, 2024

Copy link
Copy Markdown
Member Author

Passed after restart 😉

@Godin

Godin commented May 11, 2024

Copy link
Copy Markdown
Member Author

Also, I propose to create a repository based on this example with Cl build that will act as a validation test.

@marchof I assume that silence gives consent - https://github.com/jacoco/example-jacoco-kotlin-compose 😉

@marchof

marchof commented May 12, 2024

Copy link
Copy Markdown
Member

Sorry, I overlooked this comment. Sure, thanks for creating the repo.

@atulgpt

atulgpt commented May 27, 2024 •
edited
Loading

Copy link
Copy Markdown

Hi, @Godin when this fix will be available in the next release? Thanks

@Abdallah-Abdelazim

Abdallah-Abdelazim commented Jun 2, 2024

Copy link
Copy Markdown

@Godin This is a very important fix for Android projects using Jacoco. Can we please release this to the stable version?

@Godin

Godin commented Jun 4, 2024

Copy link
Copy Markdown
Member Author

See FAQ https://www.jacoco.org/jacoco/trunk/doc/faq.html

When will feature X be released?

JaCoCo is maintained by volunteers in their free time. Since we cannot guarantee free capacity, we do not commit to particular release dates. Typically, you can expect a couple of releases every year.

In the change log, you can see all features that have been implemented in master branch and will be available with the next release. And in the meantime you can test latest build of master branch (Maven SNAPSHOT) and provide feedback to us.

This was referenced Apr 3, 2025
Closed
Closed
@prakashp007 prakashp007 mentioned this pull request Mar 18, 2026
Open
@neworld neworld mentioned this pull request Jul 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marchof marchof marchof approved these changes

Assignees

@Godin Godin

Labels

component: core.filters language: Kotlin Tickets about Kotlin language support type: enhancement

Projects

Current work items
Status: Done

Milestone

0.8.13

Development

Successfully merging this pull request may close these issues.

Jacoco reports low coverage with Compose tests

4 participants

@Godin @marchof @atulgpt @Abdallah-Abdelazim