Pin public module exports - #3364

tests/main/test_public_api_signature_baseline.py (1)

631-645: 💤 Low value

Well-structured parametrized test with clear assertions.

The test logic is sound:

• Dynamically imports each module and retrieves its __all__
• Detects duplicates via set length comparison
• Validates baseline match with clear diff output
• Verifies importability (correctly triggers __getattr__ for lazy imports per context snippet)

💡 Optional: Consider reordering assertions for faster failure on fundamental errors

Moving the importability check before baseline comparison would catch fundamental errors (broken imports) before diffing:

 `@pytest.mark.parametrize`(("module_name", "expected_exports"), _PUBLIC_MODULE_EXPORTS.items())
 def test_public_module_all_exports_match_baseline(module_name: str, expected_exports: frozenset[str]) -> None:
     """Pin focused public module export surfaces used by compatibility shims."""
     module = importlib.import_module(module_name)
     module_exports = list(module.__all__)
     actual_exports = set(module_exports)
     missing_exports = [name for name in module_exports if not hasattr(module, name)]

     assert len(module_exports) == len(actual_exports), f"{module_name}.__all__ contains duplicate names"
+    assert missing_exports == [], f"{module_name}.__all__ contains non-importable names: {missing_exports}"
     assert actual_exports == expected_exports, (
         f"{module_name}.__all__ changed:\n"
         f"  removed: {sorted(expected_exports - actual_exports)}\n"
         f"  added: {sorted(actual_exports - expected_exports)}"
     )
-    assert missing_exports == [], f"{module_name}.__all__ contains non-importable names: {missing_exports}"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/main/test_public_api_signature_baseline.py` around lines 631 - 645, In
test_public_module_all_exports_match_baseline, move the importability assertion
that checks missing_exports (computed from module_exports and hasattr) to run
before the duplicate and baseline equality assertions so broken or
non-importable names fail fast; specifically, after computing module_exports,
actual_exports and missing_exports, assert missing_exports == [] first, then
proceed to the existing duplicate check (len(module_exports) vs
len(actual_exports)) and the expected_exports equality check. This keeps the
test names/variables (module_exports, actual_exports, missing_exports) and
behavior unchanged but reorders the checks for faster failure on importability
issues.