Migrate extensions-tests to JUnit Jupiter - #3840

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.84%. Comparing base (f3cf74c) to head (df0c334).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff            @@
##               main    #3840   +/-   ##
=========================================
  Coverage     86.84%   86.84%           
  Complexity     3044     3044           
=========================================
  Files           344      344           
  Lines          9172     9172           
  Branches       1135     1135           
=========================================
  Hits           7965     7965           
  Misses          917      917           
  Partials        290      290           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sorry, I don't really see the value in this. I don't see the problem with these tests depending on Hamcrest via JUnit4. Maybe I am missing the context from ten years ago, but I'd prefer just removing the TODO.

If we want to migrate all integration tests to Jupiter JUnit that's another conversation

Sorry, I don't really see the value in this. I don't see the problem with these tests depending on Hamcrest via JUnit4. Maybe I am missing the context from ten years ago, but I'd prefer just removing the TODO.

If we want to migrate all integration tests to Jupiter JUnit that's another conversation

I get your point about the TODO. I agree that we could simply drop it, but I see it as good hygiene to get rid of JUnit 4 (maintenance mode), and hamcrest also goes away as a side effect. I can retitle the PR as a Jupiter migration instead of removal of hamcrest via the Jupiter migration. The changes stay the same, but it better reflects the PR.

I guess that makes sense. I still don't think the exclude() in the gradle file is necessary (does JUnit5 even include hamcrest?) so if we drop that and address my comment in PluginStackTraceFilteringTest I'm good with merging this.

I guess that makes sense. I still don't think the exclude() in the gradle file is necessary (does JUnit5 even include hamcrest?) so if we drop that and address my comment in PluginStackTraceFilteringTest I'm good with merging this.

Makes sense to me. I doublecheck and indeed JUnit5 doesn't bring it, so I simply dropped it.

Which comment in PluginStackTraceFilteringTest you meant? I can't see it