Visitar URL original
Tighten CI by XhmikosR · Pull Request #856 · oxipng/oxipng · GitHub
Skip to content

Tighten CI - #856

Merged
AlexTMjugador merged 5 commits into
oxipng:masterfrom
XhmikosR:xmr/ci
Sep 1, 2026
Merged

AlexTMjugador merged 5 commits into
oxipng:masterfrom
XhmikosR:xmr/ci

Conversation

@XhmikosR

@XhmikosR XhmikosR commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Please check the individual patches.

The last patch doesn't save a lot, but doesn't look like it costs a lot of time anyway.

I haven't tested the deployment workflow since it needs a release.

Let me know if you want me to adapt any of the patches.

Closes #854, closes #855 along the way.

@XhmikosR
XhmikosR marked this pull request as ready for review August 19, 2026 15:41
Comment thread .github/workflows/deploy.yml
Comment thread .github/workflows/deploy.yml
Comment thread .github/workflows/deploy.yml
@XhmikosR

Copy link
Copy Markdown
Contributor Author

BTW I also made XhmikosR/oxipng@xmr/ci...XhmikosR:oxipng:xmr/hash (I used AI for the rust code), but it seems to work and will fix #727. It's built on top of this branch so I haven't opened it yet, but you can check the binaries from my fork.

@XhmikosR

Copy link
Copy Markdown
Contributor Author

Rebased and pinned all actions. I haven't tested the release workflow like I said in the PR description, but if something doesn't work feel free to CC me later and I'll have a look at it :)

@AlexTMjugador AlexTMjugador left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🚀

@AlexTMjugador
AlexTMjugador added this pull request to the merge queue Sep 1, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 1, 2026
@XhmikosR

XhmikosR commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

The clippy issue I tried to fix it in another branch by not using the nightly toolchain so that it doesn't randomly break CI. But that;s for another time...

@AlexTMjugador

Copy link
Copy Markdown
Member

I think using the nightly Rust toolchain is fine for this project, since the breakage will happen sooner or later anyway, and it's not such a big chore to fix the lints as they appear. I'll do that right now on the main branch.

@AlexTMjugador
AlexTMjugador added this pull request to the merge queue Sep 1, 2026
Merged via the queue into oxipng:master with commit 3797793 Sep 1, 2026
16 checks passed
@andrews05

Copy link
Copy Markdown
Member

@AlexTMjugador Should we do another release due to the man page issue? And to test the new workflows.

@AlexTMjugador

Copy link
Copy Markdown
Member

Should we do another release due to the man page issue? And to test the new workflows.

Sure, that sounds sensible to me! It's quite late where I am though, so if anything bad happens now with the new workflows I won't be available to immediately take a look at it.

@XhmikosR
XhmikosR deleted the xmr/ci branch September 2, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants