Visitar URL original
chore: replace Appveyor with ikalnytskyi/action-setup-postgres by vlsi · Pull Request #3966 · pgjdbc/pgjdbc · GitHub
Skip to content

chore: replace Appveyor with ikalnytskyi/action-setup-postgres - #3966

Merged
vlsi merged 1 commit into
pgjdbc:masterfrom
vlsi:windows_ci
Mar 18, 2026
Merged

vlsi merged 1 commit into
pgjdbc:masterfrom
vlsi:windows_ci

Conversation

@vlsi

@vlsi vlsi commented Mar 16, 2026 •

Copy link
Copy Markdown
Member

Fixes #2845

PG installation takes ~3 mintues. The tests take 12 minutes vs 6 minutes for the regular ubuntu runners.

The slowdown is unfortunate, however, it is still faster than Appveyor

@gitguardian

gitguardian Bot commented Mar 16, 2026 •

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic Password a15cc13 .github/workflows/main.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@vlsi

vlsi commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

I guess this is feature complete.
I guess the main cause of the slowness is the time it takes to establish connections. We could probably add connection caching in the future so parameterized tests reuse connections rather than recreate them for every parameter combination.

@bokken , @sehrope , @davecramer , do you have any comments/suggestions/objections?

@sehrope

sehrope commented Mar 17, 2026

Copy link
Copy Markdown
Member

I'd prefer to have less external dependencies in the repo over time. I took a peek at ikalnytskyi/action-setup-postgres (never hard of it before...) and it does look pretty clean. Though I don't think we need it.

I'm not sure we even need to build on Windows / MacOS or test against PostgreSQL running on either. If we just had something that could run our already build jar on those against a Linux PostgreSQL server I think it's enough. That'd solve a lot of the startup issues.

@vlsi

vlsi commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

Windows tests identified different os behavior regarding sslMode=prefer/allow fallback which look like true os-specific differences to me rather than just ability to build jar on Windows

@sehrope

sehrope commented Mar 17, 2026

Copy link
Copy Markdown
Member

And this PR touches more than just tests / appveyor. It changes how we handle ssl mode for prefer. You should call that in the title and description.

@vlsi

vlsi commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

I've extracted sslMode=allow handling to #3973

Fixes pgjdbc#2845

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vlsi
vlsi merged commit 03ea704 into pgjdbc:master Mar 18, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: Replace AppVeyor with GitHub Actions

2 participants