Visitar URL original
Restrict test with scram_iterations to v16+ and release notes by sehrope · Pull Request #4040 · pgjdbc/pgjdbc · GitHub
Skip to content

Restrict test with scram_iterations to v16+ and release notes - #4040

Merged
sehrope merged 2 commits into
pgjdbc:masterfrom
sehrope:restrict-scram-iters-test-to-v16
Apr 27, 2026
Merged

Restrict test with scram_iterations to v16+ and release notes#4040
sehrope merged 2 commits into
pgjdbc:masterfrom
sehrope:restrict-scram-iters-test-to-v16

Conversation

@sehrope

@sehrope sehrope commented Apr 27, 2026

Copy link
Copy Markdown
Member

One of the new scram max iterations tests uses the scram_iterations GUC but that's only available in v16+. So we restrict that one test accordingly via @EnabledForServerVersionRange("16").

Also updates the CHANGELOG with the fix itself.

@sehrope

sehrope commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

The one failure does not seem like it's related to this PR at all:

org.postgresql.test.jdbc2.StatementTest > fastCloses() failure marker
FAILURE  44,4sec, org.postgresql.test.jdbc2.StatementTest > fastCloses()
    java.util.concurrent.TimeoutException: fastCloses() timed out after 40 seconds
        at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
        at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)

          2,2sec, org.postgresql.test.jdbc2.StatementTest > cancelQueryWithBrokenNetwork()
          2,2sec, org.postgresql.test.jdbc2.StatementTest > sideStatementFinalizers()
          4,1sec, org.postgresql.test.jdbc2.StatementTest > setQueryTimeoutWithSleep()
          2,1sec, org.postgresql.test.jdbc2.StatementTest > setQueryTimeoutWithoutExecute()
          3,3sec, org.postgresql.test.jdbc2.StatementTest > setQueryTimeoutOnPrepared()
FAILURE  74,8sec,   43 completed,   1 failed,   0 skipped, org.postgresql.test.jdbc2.StatementTest

It runs fine locally for me and the rest of the matrix is fine too. More than likely it's related to the ongoing GitHub service interruption.

@sehrope
sehrope force-pushed the restrict-scram-iters-test-to-v16 branch from a6d799e to b04fc46 Compare April 27, 2026 17:34
@sehrope
sehrope merged commit b04fc46 into pgjdbc:master Apr 27, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sehrope