Visitar URL original
lockfile: false ignored when devEngines.packageManager.onFail: download · Issue #14728 · pnpm/pnpm · GitHub
Skip to content

lockfile: false ignored when devEngines.packageManager.onFail: download #14728

Closed

Description

@paymand

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

12.4.0

Which area(s) of pnpm are affected? (leave empty if unsure)

Lockfile

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

  1. Set devEngines.packageManager.onFail: download in package.json:
    "packageManager": {
      "name": "pnpm",
      "version": "12.4.0",
      "onFail": "download"
    }
  },
  1. Set lockfile: false in pnpm-workspace.yaml.
  2. Run pnpm i

Describe the Bug

lockfile (i.e. pnpm-lock.yaml) is created even though we instructed pnpm not to create a lockfile.
I even tried running pnpm i --no-lockfile, it still creates a lockfile.
If you set onFail: ignore, lockfile isn't created, so it seems to be related to onFail: download.

Expected Behavior

No lockfile should be created when lockfile: false is specified or --no-lockfile is used.

Which Node.js version are you using?

v24.14.0

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

Activity

  1. added theissue type on Sep 9, 2026
  2. devtechedge commented on Sep 9, 2026

    @devtechedge
    Contributor

    Looking into this — will dig into why onFail: download bypasses lockfile: false.

  3. added a commit that references this issue on Sep 10, 2026
    b84813b
  4. paymand commented on Sep 11, 2026

    @paymand
    Author

    @devtechedge is this released in 12.4.1? because I can still reproduce this issue in 12.4.1.

  5. devtechedge commented on Sep 11, 2026

    @devtechedge
    Contributor

    Hi @paymand, you're right, the fix is not in 12.4.1. PR #14753 was merged into main on Sep 10, but it landed after the v12.4.1 release was cut, so 12.4.1 still has the old behavior. It should be included in the next release (12.4.2 or later).

    Could you verify once that's out? If it's still reproducible on the next release, I'll dig back in.

  6. added a commit that references this issue on Sep 15, 2026
    fcb2ad1
  7. added a commit that references this issue on Sep 25, 2026
    624ce89
  8. paymand commented on Sep 28, 2026

    @paymand
    Author

    @devtechedge I can confirm that the lockfile isn't created anymore when I have lockfile: false in my pnpm-workspace.yaml 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions