Visitar URL original
add more of the `pulumi do` command tree as metadata by tgummerer · Pull Request #23324 · pulumi/pulumi · GitHub
Skip to content

add more of the pulumi do command tree as metadata - #23324

Merged
tgummerer merged 1 commit into
masterfrom
tg/positional-flags
May 22, 2026
Merged

tgummerer merged 1 commit into
masterfrom
tg/positional-flags

Conversation

@tgummerer

Copy link
Copy Markdown
Collaborator

Similar to pulumi plugin run, the interesting part of the command tree for pulumi do starts after the do. However since the command tree is dynamically generated, we don't capture those.

Capture the identifier and the command, as those are safe to send as metadata.

@tgummerer
tgummerer requested a review from a team as a code owner May 22, 2026 09:10
@tgummerer tgummerer added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 22, 2026
@tgummerer
tgummerer enabled auto-merge May 22, 2026 09:17
Comment thread pkg/cmd/pulumi/pulumi.go
}

if command == "pulumi do" {
positionals := positionalArgs(cmd, args)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this above for 'run' as well

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done ✔️

Similar to `pulumi plugin run`, the interesting part of the command
tree for `pulumi do` starts after the `do`.  However since the command
tree is dynamically generated, we don't capture those.

Capture the identifier and the command, as those are safe to send as
metadata.
@tgummerer
tgummerer force-pushed the tg/positional-flags branch from 22364c2 to 521a338 Compare May 22, 2026 09:22
@tgummerer
tgummerer added this pull request to the merge queue May 22, 2026
Merged via the queue into master with commit 25a9e89 May 22, 2026
232 of 234 checks passed
@tgummerer
tgummerer deleted the tg/positional-flags branch May 22, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/no-changelog-required This issue doesn't require a CHANGELOG update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants