Visitar URL original
Isolate login and credential tests from local authentication by julienp · Pull Request #24950 · pulumi/pulumi · GitHub
Skip to content

Isolate login and credential tests from local authentication - #24950

Merged
julienp merged 2 commits into
masterfrom
julienp/isolate-credentials-tests
Oct 1, 2026
Merged

julienp merged 2 commits into
masterfrom
julienp/isolate-credentials-tests

Conversation

@julienp

@julienp julienp commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Add the IsolateCredentials helper and use it in login related tests. Each test gets temporary credential directories and clears any inherited authentication settings.

Add a shared IsolateCredentials helper and use it across login, backend,
and workspace tests. Give each test temporary credential directories and
clear inherited authentication settings while preserving explicit opt-in
for agent fallback and fake secure stores.

Keep the tests in their original files for the later organization change.

Validation: make format; scoped make lint; scoped make test_fast with
-count=1 -shuffle=on (576 tests, 8 skipped).
@julienp

julienp commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor Author

@julienp julienp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 30, 2026

@Frassle Frassle left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe get rid of things like PULUMI_TEST_AGENT_PULUMI_DIR doing this?

@julienp
julienp added this pull request to the merge queue Oct 1, 2026
@julienp

julienp commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Could we maybe get rid of things like PULUMI_TEST_AGENT_PULUMI_DIR doing this?

I think we'll need some injectable CredentialStore or similar that we use throughout. I'll think a bit what that should look like, I think that fits well into the credentials helper work.

Merged via the queue into master with commit f20fdd9 Oct 1, 2026
246 of 247 checks passed
@julienp
julienp deleted the julienp/isolate-credentials-tests branch October 1, 2026 10:52
middas-0706 pushed a commit to middas-0706/pulumi that referenced this pull request Oct 1, 2026
Use the helper from pulumi#24950 for
tests using a fake credential store.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/no-changelog-required This issue doesn't require a CHANGELOG update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants