Visitar URL original
Re-organize login and backend URL tests by julienp · Pull Request #24960 · pulumi/pulumi · GitHub
Skip to content

Re-organize login and backend URL tests - #24960

Merged
julienp merged 1 commit into
julienp/auth-test-coveragefrom
julienp/organize-auth-tests
Oct 1, 2026
Merged

julienp merged 1 commit into
julienp/auth-test-coveragefrom
julienp/organize-auth-tests

Conversation

@julienp

@julienp julienp commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

There are no actual changes to the actual tests

  • Move TestGetCurrentCloudURL… tests move from pkg/cmd/pulumi/backend/backend_test.go to pkg/workspace/creds_test.go, since they test GetCurrentCloudURLWithAgentFallback from pkg/workspace/creds.go

  • Split login tests out of pkg/backend/httpstate/backend_test.go into login_{,refresh,agent,oidcs}_test.go

* Move `TestGetCurrentCloudURL…` tests move from `pkg/cmd/pulumi/backend/backend_test.go` to `pkg/workspace/creds_test.go`, since they test `GetCurrentCloudURLWithAgentFallback` from `pkg/workspace/creds.go`

* Split login tests out of `pkg/backend/httpstate/backend_test.go` into `login_{,refresh,agent,oidcs}_test.go`
@julienp

julienp commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@tgummerer tgummerer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check that every test is still the same, but the move seems sensible.

@julienp
julienp added this pull request to the merge queue Oct 1, 2026
Merged via the queue into master with commit eaf158c Oct 1, 2026
244 of 247 checks passed
@julienp
julienp deleted the julienp/organize-auth-tests branch October 1, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact/no-changelog-required This issue doesn't require a CHANGELOG update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants