Visitar URL original
Update types and jsdocs by zAlweNy26 · Pull Request #2232 · remy/nodemon · GitHub
Skip to content

Update types and jsdocs - #2232

Merged
remy merged 3 commits into
remy:mainfrom
zAlweNy26:types_docs
Apr 23, 2025
Merged

remy merged 3 commits into
remy:mainfrom
zAlweNy26:types_docs

Conversation

@zAlweNy26

Copy link
Copy Markdown
Contributor

Fix #2231

I hope I haven't missed (or messed up) anything :)

I didn't understand why there are execOptions both at first level of the settings object and also nested inside execOptions, or did I understand wrong?

@netlify

netlify Bot commented Oct 13, 2024 •

Copy link
Copy Markdown

✅ Deploy Preview for nodemon ready!

Name Link
🔨 Latest commit e205557
🔍 Latest deploy log https://app.netlify.com/sites/nodemon/deploys/678cf4caf9e6a00008f93a30
😎 Deploy Preview https://deploy-preview-2232--nodemon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread index.d.ts Resolved
remy added a commit that referenced this pull request Dec 13, 2024
Created by @zAlweNy26
PR: #2232

Modified commit to allow for squash and conventional commit
@jlowcs

jlowcs commented Jan 14, 2025 •

Copy link
Copy Markdown

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

@remy

remy commented Jan 14, 2025

Copy link
Copy Markdown
Owner

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

@jlowcs

jlowcs commented Jan 14, 2025

Copy link
Copy Markdown

Following this change, delay option has disappeared and watch and ignore options are duplicated :/

By this change are you referring to this: https://github.com/remy/nodemon/pull/2232/files ?

Or have you pulled down this PR directly and are testing it?

I'm using the latest version of nodemon and am encountering the type checking issues mentioned above.

@zAlweNy26

Copy link
Copy Markdown
Contributor Author

@remy I fixed the errors @jlowcs is talking about. Also now the export is correct.

@lcxmaple

Copy link
Copy Markdown

Is there any progress on this matter? If any code is used like this after update to version 3.1.8

import nodemon from 'nodemon'

nodemon({
  script: ''
})

then you will get a typescript error "Type 'Nodemon' has no call signatures."

It works perfectly fine in version 3.1.7.

@remy
remy merged commit 297c7c7 into remy:main Apr 23, 2025
@remy

remy commented Apr 23, 2025

Copy link
Copy Markdown
Owner

Jeez, sorry this took me so long to merge.

@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 3.1.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jlowcs

jlowcs commented May 12, 2025

Copy link
Copy Markdown

Was the watch option removed by mistake?

@remy

remy commented May 12, 2025

Copy link
Copy Markdown
Owner

Was the watch option removed by mistake?

I suspect that's the case, it's certainly still there in JS-land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing types

6 participants