Visitar URL original
Use a less surprising base-16 encoding by lukastaegert · Pull Request #5719 · rollup/rollup · GitHub
Skip to content

Use a less surprising base-16 encoding - #5719

Merged
lukastaegert merged 1 commit into
masterfrom
gh-5710_base_16
Nov 9, 2024
Merged

lukastaegert merged 1 commit into
masterfrom
gh-5710_base_16

Conversation

@lukastaegert

Copy link
Copy Markdown
Member

While not important to many, this makes it possible to recreate hashes.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: Resolves #5710

Description

This switches the order of letters and numbers when generating base-16 hashes so that it aligns more with user expectation. Maybe not too important except if people want to reverse-engineer, but also not very complicated.

While not important to many, this makes it possible to recreate hashes.
@vercel

vercel Bot commented Nov 8, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 5:52pm

@github-actions

github-actions Bot commented Nov 8, 2024 •

Copy link
Copy Markdown

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5710_base_16

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-gv2yml8v0-rollup-js.vercel.app/repl/?pr=5719

@github-actions

github-actions Bot commented Nov 8, 2024

Copy link
Copy Markdown

Performance report

  • BUILD: 8338ms, 726 MB
    • initialize: 0ms, 26.3 MB
    • generate module graph: 3165ms, 552 MB
      • generate ast: 1507ms (+43ms, +2.9%), 546 MB
    • sort and bind modules: 455ms, 599 MB
    • mark included statements: 4716ms, 726 MB
      • treeshaking pass 1: 1591ms, 693 MB
      • treeshaking pass 2: 762ms, 721 MB
      • treeshaking pass 3: 306ms, 722 MB
      • treeshaking pass 4: 279ms, 731 MB
      • treeshaking pass 5: 328ms, 724 MB
      • treeshaking pass 6: 269ms, 732 MB
      • treeshaking pass 7: 251ms, 736 MB
      • treeshaking pass 8: 245ms, 735 MB
      • treeshaking pass 9: 223ms, 732 MB
      • treeshaking pass 10: 226ms, 729 MB
      • treeshaking pass 11: 223ms, 726 MB
  • GENERATE: 909ms, 978 MB
    • initialize render: 0ms, 871 MB
    • generate chunks: 91ms, 873 MB
      • optimize chunks: 0ms, 874 MB
    • render chunks: 795ms, 956 MB
    • transform chunks: 20ms, 978 MB
    • generate bundle: 0ms, 978 MB

@codecov

codecov Bot commented Nov 8, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.02%. Comparing base (cdf34ab) to head (1d00992).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5719   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         258      258           
  Lines        8062     8062           
  Branches     1359     1359           
=======================================
  Hits         7983     7983           
  Misses         52       52           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert
lukastaegert merged commit 0f4676d into master Nov 9, 2024
@lukastaegert
lukastaegert deleted the gh-5710_base_16 branch November 9, 2024 06:40
@github-actions

github-actions Bot commented Nov 9, 2024

Copy link
Copy Markdown

This PR has been released as part of rollup@4.25.0. You can test it via npm install rollup.

This branch was successfully deployed

1 active deployment
Preview — 1d009927 Deployed Nov 8, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base16 character set used in hashes is incorrect

1 participant