Visitar URL original
[sync-review] Fix upstream manifest-synced paths blocking stranske/Travel-Plan-Permission#1498 · Issue #3343 · stranske/Workflows · GitHub
Skip to content

[sync-review] Fix upstream manifest-synced paths blocking stranske/Travel-Plan-Permission#1498 #3343

Closed as not planned

Description

@stranske

Why

Consumer sync delivery PR stranske/Travel-Plan-Permission#1498 has unresolved bot review threads on manifest-synced paths. Fix Workflows main so the next regeneration outdates consumer threads.

Scope

Resolve upstream source paths for the 12 listed manifest-synced consumer workflows under templates/consumer-repo/.github/workflows/.

Non-Goals

Do not edit consumer repositories directly.

Tasks

  • Fix templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-auto-pilot.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-autofix-dispatcher.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-guard.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-issue-optimizer.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-keepalive-loop-reporter.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/maint-coverage-guard.yml in Workflows main.
  • Fix templates/consumer-repo/.github/workflows/reusable-pr-context.yml in Workflows main.

Acceptance Criteria

  • test -f templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml && test -f templates/consumer-repo/.github/workflows/reusable-pr-context.yml passes in a fresh Workflows clone.
  • python -m pytest tests/workflows/test_workflow_agents_consolidation.py -q exits 0 on Workflows main.
  • All 12 template workflow paths exist under templates/consumer-repo/.github/workflows/.

Activity

  1. stranske commented on Sep 4, 2026

    @stranske
    OwnerAuthor

    Upstream sync review debt

    Consumer delivery PR: stranske/trip-planner#1777

    Manifest-synced paths with unresolved bot review threads:

    • consumer .github/workflows/agents-81-gate-followups.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml
    • consumer .github/workflows/agents-keepalive-loop-reporter.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-keepalive-loop-reporter.yml
    • consumer .github/workflows/maint-coverage-guard.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/maint-coverage-guard.yml
    • consumer .github/workflows/reusable-pr-context.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/reusable-pr-context.yml

    Fix these paths in Workflows main so the next sync regeneration outdates the consumer threads.

  2. stranske commented on Sep 4, 2026

    @stranske
    OwnerAuthor

    Upstream sync review debt

    Consumer delivery PR: stranske/Portable-Alpha-Extension-Model#2272

    Manifest-synced paths with unresolved bot review threads:

    • consumer .github/workflows/agents-81-gate-followups.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml
    • consumer scripts/check_deliberate_break.py → source stranske/Workflows/scripts/check_deliberate_break.py

    Fix these paths in Workflows main so the next sync regeneration outdates the consumer threads.

  3. github-actions commented on Sep 4, 2026

    @github-actions
    Contributor

    This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

    Missing required sections: Tasks, Acceptance Criteria

    Advisory:

    • 13 cited path(s) do not exist yet: stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml, .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-auto-pilot.yml, … — expected when a task creates them; check for typos otherwise.

    Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

    Dispatched the Agents Issue Optimizer format phase (attempt 1 of 3).

  4. agents-workflows-bot commented on Sep 4, 2026

    @agents-workflows-bot
    Contributor

    🏷️ Label Suggestions

    Based on the issue content, these labels might be relevant:

    • agents (95% confidence)
    • agents:keepalive (95% confidence)
    • autofix (95% confidence)
    • codex (95% confidence)
    • consumer-sync (95% confidence)
    How to use these suggestions
    • Click the label name in the sidebar to add it
    • Or use the GitHub CLI: gh issue edit 3343 --add-label "label-name"

    Auto-generated by label matcher

  5. github-actions commented on Sep 4, 2026

    @github-actions
    Contributor

    ⚠️ Workflow failed

    The agents-issue-optimizer workflow encountered an error.

    Details: View workflow run

    Format validation report:

    This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.
    
    - `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
    - `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.
    
    _Advisory:_
    - 13 cited path(s) do not exist yet: `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml`, `.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-auto-pilot.yml`, … — expected when a task creates them; check for typos otherwise.
    
  6. github-actions commented on Sep 4, 2026

    @github-actions
    Contributor

    This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

    Missing required sections: Tasks, Acceptance Criteria

    Advisory:

    • 13 cited path(s) do not exist yet: stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml, .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-auto-pilot.yml, … — expected when a task creates them; check for typos otherwise.

    Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

    Dispatched the Agents Issue Optimizer format phase (attempt 2 of 3).

  7. github-actions commented on Sep 4, 2026

    @github-actions
    Contributor

    ⚠️ Workflow failed

    The agents-issue-optimizer workflow encountered an error.

    Details: View workflow run

    Format validation report:

    This issue is **not yet agent-processable**. See `docs/AGENT_ISSUE_FORMAT.md`.
    
    - `Tasks` item must name a concrete file, symbol, path, config key, job, or command: `_Not provided._`.
    - `Acceptance Criteria` names no test, runnable command or observable verification gate — Definition of Ready / Quality Bar §2 requires one.
    
    _Advisory:_
    - 13 cited path(s) do not exist yet: `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml`, `.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml`, `stranske/Workflows/templates/consumer-repo/.github/workflows/agents-auto-pilot.yml`, … — expected when a task creates them; check for typos otherwise.
    
  8. github-actions commented on Sep 4, 2026

    @github-actions
    Contributor

    This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

    Missing required sections: Tasks, Acceptance Criteria

    Advisory:

    • 13 cited path(s) do not exist yet: stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml, .github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-81-gate-followups.yml, stranske/Workflows/templates/consumer-repo/.github/workflows/agents-auto-pilot.yml, … — expected when a task creates them; check for typos otherwise.

    Recommended but absent: Why, Scope, Implementation Notes, Non-Goals

    Dispatched the Agents Issue Optimizer format phase (attempt 3 of 3).

  9. 48 remaining items

  10. stranske-keepalive commented on Sep 5, 2026

    @stranske-keepalive
    Contributor

    ⚠️ Auto-pilot paused during formatting.

    Formatter output does not satisfy the canonical issue-format contract.

  11. stranske commented on Sep 5, 2026

    @stranske
    OwnerAuthor

    Upstream sync review debt

    Consumer delivery PR: stranske/Trend_Model_Project#6028

    Manifest-synced paths with unresolved bot review threads:

    • consumer .github/workflows/agents-71-codex-belt-dispatcher.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml
    • consumer .github/workflows/agents-72-codex-belt-worker.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-72-codex-belt-worker.yml
    • consumer .github/workflows/agents-73-codex-belt-conveyor.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-73-codex-belt-conveyor.yml
    • consumer .github/workflows/agents-guard.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-guard.yml
    • consumer .github/workflows/agents-issue-optimizer.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-issue-optimizer.yml
    • consumer .github/workflows/agents-weekly-metrics.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml
    • consumer .github/workflows/maint-coverage-guard.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/maint-coverage-guard.yml
    • consumer .github/workflows/reusable-pr-context.yml → source stranske/Workflows/templates/consumer-repo/.github/workflows/reusable-pr-context.yml
    • consumer docs/contracts/schemas/tracked-variable-v1.schema.json → source stranske/Workflows/docs/contracts/schemas/tracked-variable-v1.schema.json
    • consumer .github/scripts/keepalive_loop.js → source stranske/Workflows/.github/scripts/keepalive_loop.js
    • consumer tools/coverage_guard.py → source stranske/Workflows/tools/coverage_guard.py

    Fix these paths in Workflows main so the next sync regeneration outdates the consumer threads.

  12. stranske commented on Sep 7, 2026

    @stranske
    OwnerAuthor

    Closer lane reclaim: removing the stale status:in-progress claim.

    Evidence (checked live, 2026-09-07): this issue was labelled status:in-progress by the belt dispatcher in the 2026-09-04/05 dispatch burst. Since then: no linked PR, no commits, and no belt-dispatcher run in this repo since 2026-09-05T05:55Z. The claim is false — nothing is in progress.

    Why it could not clear itself. status:in-progress is added by agents-71-codex-belt-dispatcher.yml:435 and agents-72-codex-belt-worker.yml:1044. The only code that removes it is agents-73-codex-belt-conveyor.yml:530, which is workflow_call-only and takes pr_number as a required input (reached via reusable-70-orchestrator-main.yml:3259). So clearing the claim requires the very PR whose absence is the problem: a claim that never produced a PR can never be released. docs/LABELS.md:730 states Agents 81 also clears it after merging the linked PR — agents-81-gate-followups.yml contains no reference to the label, so that documented drain does not exist in code either.

    The mechanism defect is tracked separately; this comment only releases the claim so the issue is selectable again. No scope or acceptance criteria changed.

  13. stranske commented on Sep 9, 2026

    @stranske
    OwnerAuthor

    Closer handoff audit (2026-09-09): the local disposition ledger marked this issue as merged at 2026-09-08T23:04:55Z, but fresh repository evidence does not support a merged implementation PR. The complete issue timeline has only an issue cross-reference to #3405; no linked PR, connected event, or close event. All-state PR search for 3343 returned only old dependency PR #432, whose third-party CodeQL release notes mention github/codeql-action#3343; it is not a delivery link for this issue. Current Workflows open PR inventory is empty.

    Cleared the incorrect local merged disposition so this existing issue is visible to normal intake again. No verifier was dispatched and no completion claimed. Its source-template repair remains automation-owned; opener/source-maintenance execution should map the concrete consumer findings to a bounded Workflows source PR, then normal closer merge and verify:compare processing applies. No human action is required by this classification correction.

  14. stranske commented on Sep 9, 2026

    @stranske
    OwnerAuthor

    Source disposition from the opener audit, 2026-09-09:

    The twelve App-ID/client-ID findings in the original issue are false positives against the pinned action. actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 reads client-id || app-id and forwards the resulting value into the same authentication function (https://github.com/actions/create-github-app-token/blob/bcd2ba49218906704ab6c1aa796996da409d3eb1/main.js#L18). Workflows deliberately migrated these inputs on 2026-08-24 while keeping their numeric values; this rationale is recorded in config/template-drift-allowlist.txt. Replacing them with the deprecated spelling reverses that decision without fixing token minting.

    At fresh Workflows main afb7507, all twelve named template paths exist and the exact acceptance command python -m pytest tests/workflows/test_workflow_agents_consolidation.py -q passes (78 tests). All twelve consumer PR references collected from this issue/body/comments are now MERGED or CLOSED with zero active non-outdated review threads; full GraphQL thread bodies were inspected. Their merge state is not evidence of an implementation PR for this issue. No such linked implementation PR exists.

    I opened #3417 before completing the upstream implementation/history check, then withdrew it as superseded once that evidence showed the proposed rename was unnecessary. Closing this issue as not planned, based on the false-positive premise and existing supported implementation, not as merged delivery. No verifier is warranted for unmerged code. Future concrete source findings remain normal implementation intake; consumers remain Maint 71 owned. Audit evidence is in opener run 20260909T0202.

  15. stranske-keepalive commented on Sep 9, 2026

    @stranske-keepalive
    Contributor

    ✅ Auto-Pilot Complete

    This issue has been fully processed:

    • ✅ Issue formatted and optimized
    • ✅ Agent assigned and PR created
    • ✅ PR merged
    • ✅ Verification triggered

    Thank you for using auto-pilot! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:codexAgent-created issues from Codexagents:formattedIssue has been formatted to agent templateautomationAutomation and workflow automationconsumer-syncverify:evaluateRequest LLM evaluation of merged PR

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions