Repository navigation
variable declaration is removed unexpectedly #1351
Description
Bug report or Feature request?
Bug report
Version (complete output of terser -V or specific git commit)
terser 5.16.4
Complete CLI command or minify() options used
terser input
// test-1.js
(function (factory) {
factory(exports);
})((function (exports) {
var a = function () {
var b = 0;
var _this = {};
_this.fn = function () {
return b;
}
_this.fn2 = function () {
b += 1;
}
return _this;
}
exports.a = a;
}));Command: terser ./test-1.js --compress
terser output or error
!function(exports){var a=function(){var _this={fn:function(){return b},fn2:function(){b+=1}};return _this};exports.a=a}(exports);Expected result
This result is produced by terser 5.16.3
!function(exports){var a=function(){var b=0,_this={fn:function(){return b},fn2:function(){b+=1}};return _this};exports.a=a}(exports);Reacted by CS-Tao, Jan Hommes, Bozhidar Dedov, Dafina Karamanoleva and Tristan Bastian
Activity
fabiosantoscode commentedon Feb 23, 2023
Thanks for reporting! I suspect this change. I'll have a look tomorrow
reey commentedon Feb 23, 2023
@fabiosantoscode Seems like 8dc5fc2 broke this.. Can we revert this commit?Sorry missed your comment..fabiosantoscode commentedon Feb 23, 2023
No problem @reey! Thanks for investigating
fabiosantoscode commentedon Feb 23, 2023
Released in 5.16.5
don't assume transform functions don't mutate AST arrays. Closes ters…