Visitar URL original
Remove App Page execution mode reads by ztanner · Pull Request #96660 · vercel/next.js · GitHub
Skip to content

Remove App Page execution mode reads - #96660

Merged
ztanner merged 2 commits into
canaryfrom
ztanner/derive-app-page-behavior-from-work-unit
Aug 5, 2026
Merged

Remove App Page execution mode reads#96660
ztanner merged 2 commits into
canaryfrom
ztanner/derive-app-page-behavior-from-work-unit

Conversation

@ztanner

@ztanner ztanner commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

App Page leaf logic still reads the Work Store execution mode after request rendering and prerendering have already been separated at the entrypoint.

This change removes those remaining reads by:

  • Deriving component-tree behavior from the active Work Unit type.
  • Relying on request-only boundaries for dynamic Flight payloads and Server Actions.
  • Selecting request or prerender instrumentation context from the corresponding render pipeline.

After this change, App Page only supplies executionMode when constructing a Work Store; none of its downstream behavior reads it. Removing the field itself remains a follow-up once App Route and cache consumers have been migrated.

@github-actions

github-actions Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: 9f7147f

@github-actions

github-actions Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 2 regressions

Metric Canary PR Change Trend
Turbo Build Time 5.801s 6.112s 🔴 +311ms (+5%) ▁▂▃▁▁
Turbo Build Time (cached) 2.986s 3.195s 🔴 +209ms (+7%) ▁▂▄▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 813ms 812ms ✓ ▂▂▂▂▂
Cold (Ready in log) 794ms 800ms ✓ ▂▂▂▂▂
Cold (First Request) 1.325s 1.353s ✓ ▂▂▃▂▁
Warm (Listen) 814ms 813ms ✓ ▂▂▂▂▂
Warm (Ready in log) 806ms 792ms ✓ ▂▂▂▂▁
Warm (First Request) 1.346s 1.323s ✓ ▁▂▃▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 863ms 863ms ✓ ▄▁▁▅▅
Cold (Ready in log) 821ms 823ms ✓ ▂▁▂▄▃
Cold (First Request) 3.615s 3.560s ✓ ▁▁▁▄▃
Warm (Listen) 814ms 817ms ✓ ▄▁▁█▄
Warm (Ready in log) 819ms 816ms ✓ ▂▁▂▆▃
Warm (First Request) 3.678s 3.612s ✓ ▁▁▁▆▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.801s 6.112s 🔴 +311ms (+5%) ▁▂▃▁▁
Cached Build 2.986s 3.195s 🔴 +209ms (+7%) ▁▂▄▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.983s 25.767s ✓ ▁▃▂▆▃
Cached Build 26.177s 26.205s ✓ ▁▁▂▅▃
node_modules Size 552 MB 552 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
00mwvyrg6ixvj.js gzip 160 B N/A -
0a-p0meqxynjz.js gzip 10.3 kB N/A -
0avtke4yefj4-.js gzip 13.1 kB N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0e67499aes59m.js gzip 153 B N/A -
0ecxt13uk5yi5.js gzip 160 B N/A -
0eh7mct33fy2t.js gzip 65.6 kB N/A -
0g_a4a3kvjhcb.js gzip 170 B N/A -
0hpff96vwf5wg.js gzip 157 B N/A -
0kq_31m4cy1yc.js gzip 156 B N/A -
0pt5of3ch6d2u.js gzip 13.6 kB N/A -
0tth87xhgvqg0.js gzip 154 B N/A -
0xnsdo-6y9r3k.js gzip 5.72 kB N/A -
0yi7is8u4covm.js gzip 8.77 kB N/A -
1biacj8n3mamp.js gzip 155 B N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1fu3grgczuw0q.js gzip 71.4 kB N/A -
1fvcy6mevca8_.js gzip 155 B N/A -
1prv-wg6jgtt2.js gzip 8.77 kB N/A -
1t47vod02e_4a.js gzip 8.75 kB N/A -
1tf1phijqlx9j.js gzip 220 B 220 B ✓
1tw002sq5bo4l.js gzip 10 kB N/A -
1wlerik1n7zbr.js gzip 8.7 kB N/A -
298kcoenzq53b.js gzip 7.44 kB N/A -
2jpx0_6n0ykra.js gzip 3.66 kB N/A -
2pevdqjpbf3xk.js gzip 9.45 kB N/A -
2qd2anu9eizlz.js gzip 8.75 kB N/A -
2sv39ae5_8vfj.js gzip 8.81 kB N/A -
2utx6n7w65xqa.js gzip 8.7 kB N/A -
3-ukivglqkfeq.js gzip 8.78 kB N/A -
3044_8tfjfw1i.js gzip 158 B N/A -
325xisqrylugu.js gzip 450 B N/A -
3f2c3tys-p419.js gzip 46.3 kB N/A -
3fc7bkh7rw3rf.js gzip 155 B N/A -
3icg_udga0idh.js gzip 156 B N/A -
3jc9ghvds1spf.js gzip 2.29 kB N/A -
3juwkvkgvywfe.js gzip 10.6 kB N/A -
3kbove7q58uqh.js gzip 13.2 kB N/A -
3mgnie1ovhj25.js gzip 155 B N/A -
3qn7vntp30gaj.js gzip 1.47 kB N/A -
turbopack-07..gjbk.js gzip 3.86 kB N/A -
turbopack-0e..8-70.js gzip 3.86 kB N/A -
turbopack-0m..l2wg.js gzip 3.86 kB N/A -
turbopack-0p..d0xe.js gzip 3.88 kB N/A -
turbopack-0t..uhga.js gzip 3.86 kB N/A -
turbopack-1_..ll45.js gzip 3.86 kB N/A -
turbopack-13..1gyq.js gzip 3.86 kB N/A -
turbopack-15..cdua.js gzip 3.84 kB N/A -
turbopack-1e..w26b.js gzip 3.86 kB N/A -
turbopack-1m..hraf.js gzip 3.86 kB N/A -
turbopack-2h..2ozq.js gzip 3.86 kB N/A -
turbopack-2z..t6me.js gzip 3.86 kB N/A -
turbopack-3r..lj85.js gzip 3.86 kB N/A -
turbopack-41..5277.js gzip 3.86 kB N/A -
0_sfs0nf236wo.js gzip N/A 3.65 kB -
030a1njeh5b77.js gzip N/A 10 kB -
06s8o-lue6t9e.js gzip N/A 155 B -
0fg7be2iavl6n.js gzip N/A 168 B -
0inldqi6r-n5r.js gzip N/A 156 B -
0ot0qt5np20h7.js gzip N/A 8.78 kB -
0qitnimre00_k.js gzip N/A 156 B -
0uz1o-lwrim3w.js gzip N/A 157 B -
12m9rr7_7cexd.js gzip N/A 8.7 kB -
12ofo5lnnnsfs.js gzip N/A 156 B -
17hod4realhn2.js gzip N/A 161 B -
186r3y_rfvr0b.js gzip N/A 8.78 kB -
19v97848yrjp7.js gzip N/A 8.81 kB -
1nd_0rwgz2ozk.js gzip N/A 9.45 kB -
1oi9pltr_e10m.js gzip N/A 10.6 kB -
1rd9tzqgzsz2w.js gzip N/A 8.77 kB -
1rq1g_cwv642d.js gzip N/A 10.3 kB -
1uojw_uabeg93.js gzip N/A 450 B -
1w-7lusgyl81y.js gzip N/A 8.7 kB -
2__4f5lh7u29p.js gzip N/A 71.4 kB -
21h56wdn9zddo.js gzip N/A 8.75 kB -
2auhrzpzovkv5.js gzip N/A 46.3 kB -
2g6iw6c8ad64g.js gzip N/A 65.6 kB -
2ovff1533zvno.js gzip N/A 13.2 kB -
2s4z8jy0z7v93.js gzip N/A 1.46 kB -
2y6gb5bs4mnam.js gzip N/A 8.75 kB -
341h71ln1jpl3.js gzip N/A 2.29 kB -
34ttpt_n7605h.js gzip N/A 5.72 kB -
35qkezu10liph.js gzip N/A 162 B -
36ckfq9o-ys-a.js gzip N/A 13.1 kB -
3em63fx-8w_gc.js gzip N/A 156 B -
3nih04zcyby0u.js gzip N/A 156 B -
3ocgf72p_k0py.js gzip N/A 153 B -
3rk7h_t2arfg9.js gzip N/A 155 B -
3vdh6_u50pu5t.js gzip N/A 13.6 kB -
3yq-zkphd72-a.js gzip N/A 7.45 kB -
3zbdf4igr_egf.js gzip N/A 157 B -
turbopack-07..ddhi.js gzip N/A 3.86 kB -
turbopack-09..yxdx.js gzip N/A 3.86 kB -
turbopack-0n..ctrg.js gzip N/A 3.86 kB -
turbopack-0q..89jt.js gzip N/A 3.86 kB -
turbopack-10..mgpj.js gzip N/A 3.86 kB -
turbopack-2-..8tn0.js gzip N/A 3.86 kB -
turbopack-2f..1-rn.js gzip N/A 3.86 kB -
turbopack-2o..s9tc.js gzip N/A 3.86 kB -
turbopack-3_..3ik3.js gzip N/A 3.86 kB -
turbopack-30..6s0l.js gzip N/A 3.86 kB -
turbopack-34..cs2f.js gzip N/A 3.84 kB -
turbopack-3c..d5b2.js gzip N/A 3.86 kB -
turbopack-3v..o7-g.js gzip N/A 3.88 kB -
turbopack-3z..4q95.js gzip N/A 3.86 kB -
Total 450 kB 451 kB ⚠️ +77 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 779 B 771 B 🟢 8 B (-1%)
Total 779 B 771 B ✅ -8 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 431 B 429 B ✓
Total 431 B 429 B ✅ -2 B
Build Cache
Canary PR Change
00000001.sst gzip 13.9 MB 12.9 MB 🟢 934 kB (-7%)
00000002.sst gzip 13.9 MB 14.1 MB 🔴 +217 kB (+2%)
00000003.sst gzip 15 MB 14 MB 🟢 1.09 MB (-7%)
00000004.sst gzip 12.5 MB 14.3 MB 🔴 +1.82 MB (+15%)
00000005.sst gzip 10.3 MB 2.83 MB 🟢 7.47 MB (-73%)
00000006.sst gzip 2.83 MB 10.3 MB 🔴 +7.47 MB (+263%)
00000007.sst gzip 59 B 59 B ✓
00000008.meta gzip 89 B 89 B ✓
00000009.meta gzip 298 kB 298 kB ✓
00000010.meta gzip 299 kB 299 kB ✓
00000011.meta gzip 298 kB 298 kB ✓
00000012.sst gzip 50.4 kB 51.8 kB 🔴 +1.48 kB (+3%)
00000013.sst gzip 1.91 MB 1.89 MB 🟢 16.4 kB (-1%)
00000014.sst gzip 59 B 59 B ✓
00000015.meta gzip 116 B 116 B ✓
00000016.meta gzip 324 kB 324 kB ✓
00000017.meta gzip 405 kB 405 kB ✓
00000018.sst gzip 51.1 kB 52.4 kB 🔴 +1.25 kB (+2%)
00000019.sst gzip 1.4 MB 1.39 MB 🟢 11.9 kB (-1%)
00000020.sst gzip 59 B 59 B ✓
00000021.meta gzip 116 B 116 B ✓
00000022.meta gzip 324 kB 324 kB ✓
00000023.meta gzip 370 kB 370 kB ✓
00000024.sst gzip 51.1 kB 52.4 kB 🔴 +1.31 kB (+3%)
00000025.sst gzip 1.4 MB 1.39 MB 🟢 12.1 kB (-1%)
00000026.sst gzip 59 B 59 B ✓
00000027.meta gzip 116 B 116 B ✓
00000028.meta gzip 324 kB 324 kB ✓
00000029.meta gzip 370 kB 370 kB ✓
00000030.sst gzip 50.4 kB 51.9 kB 🔴 +1.48 kB (+3%)
00000031.sst gzip 1.4 MB 1.39 MB 🟢 11.5 kB (-1%)
00000032.sst gzip 59 B 59 B ✓
00000033.meta gzip 116 B 116 B ✓
00000034.meta gzip 324 kB 324 kB ✓
00000035.meta gzip 370 kB 370 kB ✓
00000036.sst gzip 51.1 kB 52.3 kB 🔴 +1.2 kB (+2%)
00000037.sst gzip 1.4 MB 1.39 MB 🟢 11.5 kB (-1%)
00000038.sst gzip 59 B 59 B ✓
00000039.meta gzip 116 B 116 B ✓
00000040.meta gzip 324 kB 324 kB ✓
00000041.meta gzip 370 kB 370 kB ✓
CURRENT gzip 24 B 24 B ✓
LOG gzip 679 B 673 B ✓
Total 80.6 MB 80.6 MB ✅ -45.5 kB

📦 Webpack

Client

Main Bundles
Canary PR Change
3322-HASH.js gzip 65 kB N/A -
4191.HASH.js gzip 169 B N/A -
7920-HASH.js gzip 4.68 kB N/A -
9784-HASH.js gzip 5.63 kB N/A -
b1ad9f4c-HASH.js gzip 63.2 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 254 B 253 B ✓
main-HASH.js gzip 40 kB 40 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
3577.HASH.js gzip N/A 168 B -
578-HASH.js gzip N/A 65.8 kB -
8590-HASH.js gzip N/A 5.61 kB -
9750-HASH.js gzip N/A 4.69 kB -
a8984546-HASH.js gzip N/A 63.2 kB -
Total 240 kB 241 kB ⚠️ +706 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 181 B 182 B ✓
css-HASH.js gzip 334 B 331 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 255 B 253 B ✓
head-HASH.js gzip 349 B 351 B ✓
hooks-HASH.js gzip 382 B 384 B ✓
image-HASH.js gzip 581 B 582 B ✓
index-HASH.js gzip 260 B 259 B ✓
link-HASH.js gzip 2.48 kB 2.48 kB ✓
routerDirect..HASH.js gzip 317 B 318 B ✓
script-HASH.js gzip 384 B 386 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.95 kB 7.95 kB ⚠️ +1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 129 kB 128 kB ✓
page.js gzip 293 kB 294 kB ✓
Total 422 kB 423 kB ⚠️ +645 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 618 B ✓
middleware-r..fest.js gzip 156 B 156 B ✓
middleware.js gzip 45.5 kB 45.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 47.1 kB 46.8 kB ✅ -254 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 718 B 718 B ✓
Total 718 B 718 B ✓
Build Cache
Canary PR Change
0.pack gzip 4.86 MB 4.86 MB ✓
index.pack gzip 123 kB 124 kB ✓
index.pack.old gzip 124 kB 123 kB ✓
Total 5.11 MB 5.11 MB ✅ -3.53 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 374 kB 374 kB ✓
app-page-exp..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 373 kB 373 kB ✓
app-page-tur..prod.js gzip 206 kB 206 kB ✓
app-page-tur...dev.js gzip 370 kB 370 kB ✓
app-page-tur..prod.js gzip 204 kB 204 kB ✓
app-page.run...dev.js gzip 370 kB 370 kB ✓
app-page.run..prod.js gzip 204 kB 204 kB ✓
app-route-ex...dev.js gzip 83 kB 83 kB ✓
app-route-ex..prod.js gzip 56.2 kB 56.2 kB ✓
app-route-tu...dev.js gzip 83.1 kB 83.1 kB ✓
app-route-tu..prod.js gzip 56.2 kB 56.2 kB ✓
app-route-tu...dev.js gzip 82.6 kB 82.6 kB ✓
app-route-tu..prod.js gzip 55.9 kB 55.9 kB ✓
app-route.ru...dev.js gzip 82.6 kB 82.6 kB ✓
app-route.ru..prod.js gzip 55.9 kB 55.9 kB ✓
dev-validati...dev.js gzip 133 kB 133 kB ✓
dev-validati...dev.js gzip 133 kB 133 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dev-validati...dev.js gzip 131 kB 131 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 46 kB 46 kB ✓
pages-api-tu..prod.js gzip 34.3 kB 34.3 kB ✓
pages-api.ru...dev.js gzip 45.9 kB 45.9 kB ✓
pages-api.ru..prod.js gzip 34.3 kB 34.3 kB ✓
pages-turbo....dev.js gzip 54.7 kB 54.7 kB ✓
pages-turbo...prod.js gzip 39.8 kB 39.8 kB ✓
pages.runtim...dev.js gzip 54.7 kB 54.7 kB ✓
pages.runtim..prod.js gzip 39.8 kB 39.8 kB ✓
server.runti..prod.js gzip 66.9 kB 66.9 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 72.3 kB 72.3 kB ✓
use-cache-pr...dev.js gzip 70.6 kB 70.6 kB ✓
use-cache-pr...dev.js gzip 70.6 kB 70.6 kB ✓
Total 4.09 MB 4.09 MB ⚠️ +32 B
📝 Changed Files (8 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/9f7147f4318d342ee03394ac54fc87efa2278fac/next

Commit: 9f7147f

@ztanner
ztanner marked this pull request as ready for review August 4, 2026 21:14
gnoff
gnoff reviewed Aug 4, 2026
View reviewed changes
Comment thread packages/next/src/server/app-render/create-component-tree.tsx Outdated
gnoff
gnoff reviewed Aug 4, 2026
View reviewed changes
Comment thread packages/next/src/server/app-render/create-component-tree.tsx Outdated
@ztanner
ztanner force-pushed the ztanner/derive-app-page-behavior-from-work-unit branch from 746130c to c60ba9b Compare August 4, 2026 23:26
@ztanner
ztanner force-pushed the ztanner/derive-app-page-behavior-from-work-unit branch from c60ba9b to 32332b2 Compare August 5, 2026 00:16
@ztanner
ztanner force-pushed the ztanner/derive-app-page-behavior-from-work-unit branch 2 times, most recently from de68f5c to e538456 Compare August 5, 2026 00:55
Base automatically changed from ztanner/separate-app-page-render-pipelines to canary August 5, 2026 12:51
@ztanner
ztanner force-pushed the ztanner/derive-app-page-behavior-from-work-unit branch from e538456 to 9f7147f Compare August 5, 2026 13:23
gnoff
gnoff approved these changes Aug 5, 2026
View reviewed changes

@gnoff gnoff left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another refactor we should consider is splitting createComponentTree by CC. There are a ton of legacy code paths in here that limit how tight we can make this function. the revalidate assignment for instance would just go away if we didn't have to consider non-CC. It would of course increase the surface area for common changes but I think there is benefit to narrowing the "context" of complex functions like these even if it means making double changes sometimes

@ztanner
ztanner merged commit faaab1a into canary Aug 5, 2026
230 of 234 checks passed
@ztanner
ztanner deleted the ztanner/derive-app-page-behavior-from-work-unit branch August 5, 2026 16:53
m-kawafuji pushed a commit to m-kawafuji/next.js that referenced this pull request Aug 8, 2026
@ztanner @m-kawafuji
Remove App Page execution mode reads (vercel#96660)
53a96a6 
## Summary

App Page leaf logic still reads the Work Store execution mode after
request rendering and prerendering have already been separated at the
entrypoint.

This change removes those remaining reads by:

- Deriving component-tree behavior from the active Work Unit type.
- Relying on request-only boundaries for dynamic Flight payloads and
Server Actions.
- Selecting request or prerender instrumentation context from the
corresponding render pipeline.

After this change, App Page only supplies `executionMode` when
constructing a Work Store; none of its downstream behavior reads it.
Removing the field itself remains a follow-up once App Route and cache
consumers have been migrated.
@github-actions github-actions Bot added the locked label Sep 6, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gnoff gnoff gnoff approved these changes

Assignees

No one assigned

Labels

locked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ztanner @gnoff