Visitar URL original
fix: syntax error when comment is on the last line by hai-x · Pull Request #19805 · webpack/webpack · GitHub
Skip to content

fix: syntax error when comment is on the last line - #19805

Merged
alexander-akait merged 1 commit into
mainfrom
issue-19799
Aug 14, 2025
Merged

alexander-akait merged 1 commit into
mainfrom
issue-19799

Conversation

@hai-x

@hai-x hai-x commented Aug 14, 2025

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Fixes #19799.

We now prepend ESM export statement before generated concatenated module code.

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@hai-x
hai-x marked this pull request as ready for review August 14, 2025 13:24
@codspeed

codspeed Bot commented Aug 14, 2025 •

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #19805 will improve performances by ×15

Comparing issue-19799 (7bd4cbf) with main (c21b4e2)

Summary

⚡ 3 improvements
✅ 39 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 100.7 ms 36.5 ms ×2.8
⚡ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 874.2 ms 58.5 ms ×15
⚡ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 121.5 ms 93.5 ms +30%

@alexander-akait
alexander-akait merged commit f0da8c6 into main Aug 14, 2025
@alexander-akait
alexander-akait deleted the issue-19799 branch August 14, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax Error in Bundle cause by missing newline

2 participants