Visitar URL original
Merge branch 'develop' of github.com:uswds/uswds into gsq-xss-audit · uswds/uswds@ff30ee4 · GitHub
Skip to content

Commit ff30ee4

Browse files
Merge branch 'develop' of github.com:uswds/uswds into gsq-xss-audit
2 parents 37bce34 + 08733d5 commit ff30ee4

10 files changed

Lines changed: 22 additions & 30 deletions

File tree

‎SECURITY.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Our security policies and procedures
44

5-
We follow GSA's [IT security policy](https://www.gsa.gov/directive/gsa-information-technology-%28it%29-security-policy) to ensure the confidentiality, integrity, and availability of USWDS.
5+
We follow GSA's [IT security policy](https://www.gsa.gov/policy-regulations/policy/information-integrity-and-access/gsa-it-security-policies) to ensure the confidentiality, integrity, and availability of USWDS.
66

77
We use [Snyk](https://snyk.io) to find, fix, and prevent vulnerabilities in USWDS dependencies. We run Snyk checks locally during development and automatically on all pull requests.
88

‎docs/WHO_IS_USING_USWDS.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ Below are a list of websites and applications currently using the U.S. Web Desig
134134
- [U.S. Army Medical Center of Excellence (MEDCoE)](https://medcoe.army.mil)
135135
- [U.S. Data Federation](http://federation.data.gov/)
136136
- [U.S. Department of Agriculture (USDA)](https://www.usda.gov/)
137+
- [U.S. Department of Justice - Civil Rights Division](https://civilrights.justice.gov/)
137138
- [U.S. Department of Labor](https://www.dol.gov/)
138139
- [U.S. Department of the Treasury](https://treasury.gov)
139140
- [U.S. Department of Veterans Affairs](https://va.gov)

‎src/components/collection/collection--fancy-date.njk‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<ul class="usa-collection">
22
<li class="usa-collection__item">
3-
<div class="usa-collection__calendar-date" href="https://www.performance.gov/presidents-winners-press-release/">
3+
<div class="usa-collection__calendar-date">
44
<time datetime="2020-09-30T12:00:00+01:00">
55
<span class="usa-collection__calendar-date-month">SEP</span>
66
<span class="usa-collection__calendar-date-day">30</span>
@@ -14,7 +14,7 @@
1414
</div>
1515
</li>
1616
<li class="usa-collection__item">
17-
<div class="usa-collection__calendar-date" href="https://www.performance.gov/sba-wosb-dashboard/">
17+
<div class="usa-collection__calendar-date">
1818
<time datetime="2020-09-30T12:00:00+01:00">
1919
<span class="usa-collection__calendar-date-month">SEP</span>
2020
<span class="usa-collection__calendar-date-day">30</span>
@@ -28,7 +28,7 @@
2828
</div>
2929
</li>
3030
<li class="usa-collection__item">
31-
<div class="usa-collection__calendar-date" href="https://www.performance.gov/September-2020-Updates-Show-Progress/">
31+
<div class="usa-collection__calendar-date">
3232
<time datetime="2020-09-17T12:00:00+01:00">
3333
<span class="usa-collection__calendar-date-month">SEP</span>
3434
<span class="usa-collection__calendar-date-day">17</span>

‎src/img/usa-icons-bg/launch--blue-60v.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎src/img/usa-icons-bg/launch--blue-70v.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎src/img/usa-icons-bg/launch--gray-5.svg‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎src/js/components/file-input.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,8 @@ const preventInvalidFiles = (e, fileInputEl, instructions, dropTarget) => {
359359
removeOldPreviews(dropTarget, instructions);
360360
fileInputEl.value = ""; // eslint-disable-line no-param-reassign
361361
dropTarget.insertBefore(errorMessage, fileInputEl);
362-
errorMessage.innerHTML = `This is not a valid file type.`;
362+
errorMessage.textContent =
363+
fileInputEl.dataset.errormessage || `This is not a valid file type.`
363364
errorMessage.classList.add(ACCEPTED_FILE_MESSAGE_CLASS);
364365
dropTarget.classList.add(INVALID_FILE_CLASS);
365366
TYPE_IS_VALID = false;
Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
@mixin external-link(
2-
$external-link,
3-
$external-link-hover,
4-
$image-path: $theme-image-path
5-
) {
1+
$external-link-size: 1.75ex;
2+
3+
$icon-object: (
4+
"name": "launch",
5+
"color": currentColor,
6+
"height": $external-link-size,
7+
"svg-height": 24,
8+
"svg-width": 24,
9+
);
10+
11+
@mixin external-link($contrast-bg: "default") {
612
&::after {
7-
$external-link-size: 1.75ex;
8-
background-image: url("#{$image-path}/#{$external-link}.svg");
9-
background-repeat: no-repeat;
10-
background-size: 100%;
13+
@include add-color-icon($icon-object, $contrast-bg);
1114
content: "";
1215
height: $external-link-size;
1316
margin-left: units(2px);
@@ -17,8 +20,4 @@
1720
padding-left: $external-link-size;
1821
vertical-align: middle;
1922
}
20-
21-
&:hover::after {
22-
@include add-background-svg("#{$external-link-hover}", $image-path);
23-
}
2423
}

‎src/stylesheets/core/mixins/_icon.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
// Mask supported styles
140140
@supports (mask: url("")) {
141141
background: none;
142-
background-color: color($color);
142+
background-color: if($color == currentColor, $color, color($color));
143143
mask: $mask-props;
144144
@if $color-hover {
145145
&:hover {

‎src/stylesheets/elements/typography/_links.scss‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,9 @@
77
// [href^='https:']:not([href*='my-domain.com'])
88

99
.usa-link--external {
10-
@include external-link(
11-
usa-icons-bg/launch--blue-60v,
12-
usa-icons-bg/launch--blue-70v
13-
);
10+
@include external-link();
1411

1512
&.usa-link--alt {
16-
@include external-link(
17-
usa-icons-bg/launch--gray-5,
18-
usa-icons-bg/launch--white
19-
);
13+
@include external-link($contrast-bg: "base-darker");
2014
}
2115
}

0 commit comments

Comments
 (0)