Visitar URL original
Verify non-GKE resources map to `k8s_*` monitored resources · Issue #258 · GoogleCloudPlatform/opentelemetry-operations-java · GitHub
Skip to content

Verify non-GKE resources map to k8s_* monitored resources #258

New issue
New issue
Closed
#340
Closed
Verify non-GKE resources map to k8s_* monitored resources#258
#340
Labels
enhancementNew feature or requestenhancement acceptedAn actionable enhancement for which PRs will be acceptedgood first issueGood for newcomerspriority: p2

Description

@damemi
damemi
opened on Jul 26, 2023

From GoogleCloudPlatform/opentelemetry-operations-go#627, verify that kubernetes resources do not require cloud.platform: gcp_kubernetes_engine to map to k8s Monitored Resources (k8s_container, k8s_pod, etc).

Go exporter/collector fix in GoogleCloudPlatform/opentelemetry-operations-go#683 uses k8s.cluster.name resource attribute to identify a k8s resource. Other languages should be consistent with this.

Activity

  1. aabmass
    added
    enhancementNew feature or request
    good first issueGood for newcomers
    priority: p2
    enhancement acceptedAn actionable enhancement for which PRs will be accepted
    on Jul 31, 2023

  2. aabmass commented on Jul 31, 2023

    @aabmass
    aabmass
    on Jul 31, 2023
    Contributor

    Triaged. If anyone would like to work on this please leave a comment.

  3. tkmsaaaam
    added a commit that references this issue on May 6, 2024

    Fix GoogleCloudPlatform#258 enable mapping when not gcp kubernetes

    e5f4d84

  4. tkmsaaaam commented on May 6, 2024

    @tkmsaaaam
    tkmsaaaam
    on May 6, 2024
    Contributor

    I created this PR. #340 Please review it.

  5. psx95
    added 2 commits that reference this issue on May 10, 2024

    Merge pull request #3 from tkmsaaaam/fix-issue-258

    4dc330c

    Fix #258 enable mapping when not gcp kubernetes (#340)

    77ac82a
  6. psx95
    closed this as completedin #340on May 10, 2024

  7. tkmsaaaam commented on May 11, 2024

    @tkmsaaaam
    tkmsaaaam
    on May 11, 2024
    Contributor

    My apologize. I fixed this issue. But I noticed it contained bug. So I fixed it. Please review it.
    #342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestenhancement acceptedAn actionable enhancement for which PRs will be acceptedgood first issueGood for newcomerspriority: p2

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions