Visitar URL original
feature: add a `python-path` output by mayeut · Pull Request #405 · actions/setup-python · GitHub
Skip to content

feature: add a python-path output - #405

Merged
marko-zivic-93 merged 1 commit into
actions:mainfrom
mayeut:interpreter-path
May 25, 2022
Merged

feature: add a python-path output#405
marko-zivic-93 merged 1 commit into
actions:mainfrom
mayeut:interpreter-path

Conversation

@mayeut

@mayeut mayeut commented May 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:
Expose a python-path output containing the chosen Python executable path.

Related issue:
fix #309
mitigate #132

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mayeut
mayeut requested a review from a team May 22, 2022 12:03
brcrista
brcrista reviewed May 23, 2022
View reviewed changes
Comment thread action.yml Resolved
@mayeut
mayeut force-pushed the interpreter-path branch from 57e517c to b39eda6 Compare May 23, 2022 19:02
@mayeut mayeut changed the title feature: add an interpreter-path output feature: add a python-path output May 23, 2022
brcrista
brcrista reviewed May 23, 2022
View reviewed changes
Comment thread .github/workflows/test-python.yml Resolved
@mayeut
mayeut force-pushed the interpreter-path branch from b39eda6 to fa35c81 Compare May 23, 2022 20:22
@mayeut

mayeut commented May 24, 2022

Copy link
Copy Markdown
Contributor Author

The failure for e2e-cache / Test poetry (Python pypy-3.7-v7.x, windows-latest) seems unrelated to changes in this PR.

@vsafonkin

vsafonkin commented May 24, 2022

Copy link
Copy Markdown

Hi @mayeut, why you don't want to use pythonLocation environment variable for this purpose?

@henryiii

henryiii commented May 24, 2022

Copy link
Copy Markdown

The output works doesn't rely on modifying the environment, and doesn't get overwritten. So you could do multiple setup-python's, and access the correct output. An example of this might be problematic:

- uses: actions/setup-python@v3
  with:
    python-version: "3.7"
- uses: some/composite-action@v1 # Runs a different setup-python internally
# Now pythonLocation is no longer the 3.7 one!

vsafonkin
vsafonkin reviewed May 24, 2022
View reviewed changes
Comment thread .github/workflows/test-python.yml Resolved
brcrista
brcrista reviewed May 24, 2022
View reviewed changes
Comment thread action.yml Resolved
@mayeut
feature: add a python-path output
ff70656 
Expose a `python-path` output containing the chosen Python executable path.
@mayeut
mayeut force-pushed the interpreter-path branch from fa35c81 to ff70656 Compare May 24, 2022 19:02
@mayeut

mayeut commented May 24, 2022

Copy link
Copy Markdown
Contributor Author

The failure for e2e-cache / Test poetry (Python pypy-3.7-v7.x, windows-latest) seems unrelated to changes in this PR.
(the previous failure on the same test went away with a relaunch of the workflow by @vsafonkin)

@marko-zivic-93
marko-zivic-93 merged commit 081a3cf into actions:main May 25, 2022
@mayeut
mayeut deleted the interpreter-path branch May 25, 2022 21:36
@webknjaz webknjaz mentioned this pull request Aug 15, 2022
Closed
tdfacer pushed a commit to ifit/setup-python that referenced this pull request Oct 7, 2025
@marko-zivic-93
Merge pull request actions#405 from mayeut/interpreter-path
5c30dce 
feature: add a `python-path` output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@vsafonkin vsafonkin vsafonkin approved these changes
@brcrista brcrista brcrista approved these changes
@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR] Expose an interpreter-path output containing the chosen Python executable path

5 participants

@mayeut @vsafonkin @henryiii @brcrista @marko-zivic-93