Visitar URL original
call resource based fab methods. by jhtimmins · Pull Request #16190 · apache/airflow · GitHub
Skip to content

call resource based fab methods. - #16190

Merged
jhtimmins merged 1 commit into
apache:mainfrom
astronomer:call-resource-based-fab-methods
Jun 1, 2021
Merged

jhtimmins merged 1 commit into
apache:mainfrom
astronomer:call-resource-based-fab-methods

Conversation

@jhtimmins

Copy link
Copy Markdown
Contributor

The previous PR (#16077) added wrappers that use the updated resource/action names around the default FAB methods. This PR updates security.py to use those new methods.

Successor to #16077 and the next step in #15398.

This PR can be merged whenever it passes.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Jun 1, 2021
@jhtimmins

Copy link
Copy Markdown
Contributor Author

@ashb @jedcunningham @kaxil If one of y'all can take a look at this. This can be merged whenever it passes.

Thanks!

@jhtimmins
jhtimmins requested review from ashb, jedcunningham and kaxil June 1, 2021 06:33
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 1, 2021
@github-actions

github-actions Bot commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@jhtimmins
jhtimmins merged commit 65ee91d into apache:main Jun 1, 2021
@jhtimmins
jhtimmins deleted the call-resource-based-fab-methods branch June 1, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants