Visitar URL original
deprecate dummy trigger rule infavor of always by eladkal · Pull Request #17144 · apache/airflow · GitHub
Skip to content

deprecate dummy trigger rule infavor of always - #17144

Merged
potiuk merged 1 commit into
apache:mainfrom
eladkal:dummy
Jul 29, 2021
Merged

deprecate dummy trigger rule infavor of always#17144
potiuk merged 1 commit into
apache:mainfrom
eladkal:dummy

Conversation

@eladkal

@eladkal eladkal commented Jul 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of #15994

This PR handles:

  • Deprecating dummy trigger rule.
  • Introducing null always trigger rule.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

o-nikolas
o-nikolas reviewed Jul 21, 2021
View reviewed changes
Comment thread docs/apache-airflow/concepts/dags.rst Resolved
jedcunningham
jedcunningham reviewed Jul 21, 2021
View reviewed changes
Comment thread tests/models/test_baseoperator.py Resolved
@eladkal eladkal mentioned this pull request Jul 22, 2021
Closed
@ashb

ashb commented Jul 28, 2021

Copy link
Copy Markdown
Member

I'm with @o-nikolas -- how about we are more explicit here and say what it does: "always"

@github-actions

github-actions Bot commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 28, 2021
@eladkal eladkal changed the title deprecate dummy trigger rule infavor of null deprecate dummy trigger rule infavor of always Jul 28, 2021
@eladkal eladkal added this to the Airflow 2.2 milestone Jul 28, 2021
kaxil
kaxil reviewed Jul 28, 2021
View reviewed changes

@kaxil kaxil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a note to Updating.md too

@eladkal

eladkal commented Jul 29, 2021

Copy link
Copy Markdown
Contributor Author

addressed all comments - should be good to go now.
test failures seem to be unrelated.
I'm leaving the merge decision for one of the PMCs as I'm not sure if we should wait for more voices or the always name is the one to be.

@potiuk
potiuk merged commit d7a6856 into apache:main Jul 29, 2021
@eladkal
eladkal deleted the dummy branch July 29, 2021 13:29
@shahar1 shahar1 mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaxil kaxil kaxil left review comments
@potiuk potiuk potiuk approved these changes
@uranusjr uranusjr uranusjr approved these changes
@o-nikolas o-nikolas o-nikolas approved these changes
@jedcunningham jedcunningham jedcunningham approved these changes
@ashb ashb Awaiting requested review from ashb
@turbaszek turbaszek Awaiting requested review from turbaszek
@XD-DENG XD-DENG Awaiting requested review from XD-DENG

Assignees

No one assigned

Labels

full tests needed We need to run full set of tests for this PR to merge kind:documentation

Projects

None yet

Milestone

Airflow 2.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@eladkal @ashb @potiuk @uranusjr @kaxil @o-nikolas @jedcunningham