Visitar URL original
Doc: Recommend using same configs on all Airflow components by kaxil · Pull Request #17146 · apache/airflow · GitHub
Skip to content

Doc: Recommend using same configs on all Airflow components - #17146

Merged
kaxil merged 1 commit into
apache:mainfrom
astronomer:add-docs-configs
Jul 21, 2021
Merged

kaxil merged 1 commit into
apache:mainfrom
astronomer:add-docs-configs

Conversation

@kaxil

@kaxil kaxil commented Jul 21, 2021

Copy link
Copy Markdown
Member

Some users seem to be using different configs for different components. This doc makes it clear on what we recommend.

Context: #16754 (comment)

I'm new to Airflow and I haven't seen an explicit part within the docs that says "all configuration must be shared between airflow components". In fact, all configuration keys are prefixed with some naming scheme which led me to think that some are common, some are for webserver etc... I personally don't like to have common configuration because changing a single setting requires a change in all components (hence restart) but I get that this is intentional for Airflow. I think this can be better communicated throughout the docs.

cc @tunix


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Some users seem to be using different configs for different components. This doc makes it clear on what we recommend.

Context: apache#16754 (comment)

>I'm new to Airflow and I haven't seen an explicit part within the docs that says "all configuration must be shared between airflow components". In fact, all configuration keys are prefixed with some naming scheme which led me to think that some are common, some are for webserver etc... I personally don't like to have common configuration because changing a single setting requires a change in all components (hence restart) but I get that this is intentional for Airflow. I think this can be better communicated throughout the docs.

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! YES! YES!

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jul 21, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil
kaxil merged commit 3a263ab into apache:main Jul 21, 2021
@kaxil
kaxil deleted the add-docs-configs branch July 21, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants