Visitar URL original
logs task launch exception in standard task runner by Narendra-Neerukonda · Pull Request #17967 · apache/airflow · GitHub
Skip to content

logs task launch exception in standard task runner - #17967

Merged
ashb merged 1 commit into
apache:mainfrom
Narendra-Neerukonda:error_message
Sep 3, 2021
Merged

logs task launch exception in standard task runner#17967
ashb merged 1 commit into
apache:mainfrom
Narendra-Neerukonda:error_message

Conversation

@Narendra-Neerukonda

@Narendra-Neerukonda Narendra-Neerukonda commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

closes: #17966

Adds an error log message to task runner when task launch fails with error code 1

xinbinhuang
xinbinhuang reviewed Sep 2, 2021
View reviewed changes
Comment thread airflow/task/task_runner/standard_task_runner.py Resolved
@Narendra-Neerukonda

Narendra-Neerukonda commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

commit updated as per suggestions from @xinbinhuang and @uranusjr

uranusjr
uranusjr reviewed Sep 2, 2021
View reviewed changes
Comment thread airflow/task/task_runner/standard_task_runner.py Resolved
@uranusjr

uranusjr commented Sep 2, 2021

Copy link
Copy Markdown
Member

Please fix the linter error. It’s be best if you could set up pre-commit locally and check the commit before pushing 🙂

@github-actions

github-actions Bot commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 2, 2021
@uranusjr uranusjr removed the full tests needed We need to run full set of tests for this PR to merge label Sep 2, 2021
@Narendra-Neerukonda @ydodeja365
logs task launch exception in standard task runner
bbf30a4 
Co-authored-by: Yash Dodeja <ydodeja365@gmail.com>
@ashb
ashb merged commit b6a962c into apache:main Sep 3, 2021
@boring-cyborg

boring-cyborg Bot commented Sep 3, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinbinhuang xinbinhuang xinbinhuang left review comments
@uranusjr uranusjr uranusjr approved these changes

Assignees

No one assigned

Labels

area:scheduler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

lack of definitive error message if task launch fails

4 participants

@Narendra-Neerukonda @uranusjr @xinbinhuang @ashb