Repository navigation
Fixes incorrect parameter passed to views (#18083) - #18085
Merged
Merged
Conversation
Member
|
@robinedwards LGTM -- I'm guessing this should be included in 2.1.4 too? |
Contributor
Author
|
If there is going to be a 2.1.4 that would be much appreciated :-) |
The task_stats, last_dagruns, blocked etc expect dag_ids not dagIds. This caused the endpoint to return all dags the user had access to by default
robinedwards
force-pushed
the
hotfix/dag-ids-view-parameter
branch
from
September 8, 2021 14:41
eef2f4a to
2b2c104
Compare
robinedwards
requested review from
XD-DENG,
dimberman,
ephraimbuddy,
jhtimmins,
kaxil,
mik-laj,
potiuk,
turbaszek and
vikramkoka
as code owners
September 8, 2021 14:41
kaxil
approved these changes
Sep 8, 2021
Contributor
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
pushed a commit
that referenced
this pull request
Sep 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task_stats, last_dagruns, blocked etc expect dag_ids not dagIds.
This caused the endpoint to return all dags the user had access to by default
closes: #18083