Visitar URL original
Fixes incorrect parameter passed to views (#18083) by robinedwards · Pull Request #18085 · apache/airflow · GitHub
Skip to content

Fixes incorrect parameter passed to views (#18083) - #18085

Merged
kaxil merged 1 commit into
apache:mainfrom
robinedwards:hotfix/dag-ids-view-parameter
Sep 8, 2021
Merged

kaxil merged 1 commit into
apache:mainfrom
robinedwards:hotfix/dag-ids-view-parameter

Conversation

@robinedwards

Copy link
Copy Markdown
Contributor

The task_stats, last_dagruns, blocked etc expect dag_ids not dagIds.

This caused the endpoint to return all dags the user had access to by default

closes: #18083

@boring-cyborg boring-cyborg Bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 8, 2021
@ashb

ashb commented Sep 8, 2021

Copy link
Copy Markdown
Member

@robinedwards LGTM -- I'm guessing this should be included in 2.1.4 too?

@ashb ashb added this to the Airflow 2.1.4 milestone Sep 8, 2021
@robinedwards

Copy link
Copy Markdown
Contributor Author

If there is going to be a 2.1.4 that would be much appreciated :-)

The task_stats, last_dagruns, blocked etc expect dag_ids not dagIds.

This caused the endpoint to return all dags the user had access to by
default
@robinedwards
robinedwards force-pushed the hotfix/dag-ids-view-parameter branch from eef2f4a to 2b2c104 Compare September 8, 2021 14:41
@robinedwards
robinedwards changed the base branch from v2-1-stable to main September 8, 2021 14:42
@kaxil
kaxil merged commit d6e48cd into apache:main Sep 8, 2021
@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 8, 2021
@github-actions

github-actions Bot commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

kaxil pushed a commit that referenced this pull request Sep 10, 2021
The task_stats, last_dagruns, blocked etc expect dag_ids not dagIds.

This caused the endpoint to return all dags the user had access to by
default

closes: #18083
(cherry picked from commit d6e48cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect parameter posted to last_dagruns, task_stats, blocked etc

3 participants