Visitar URL original
add sla_miss_callback section to the documentation by alex-astronomer · Pull Request #18305 · apache/airflow · GitHub
Skip to content

add sla_miss_callback section to the documentation - #18305

Merged
potiuk merged 1 commit into
apache:mainfrom
alex-astronomer:15641-sla-miss-callback-docs
Sep 18, 2021
Merged

potiuk merged 1 commit into
apache:mainfrom
alex-astronomer:15641-sla-miss-callback-docs

Conversation

@alex-astronomer

Copy link
Copy Markdown
Contributor

Closes: #15641

Adds documentation for sla_miss_callback. Also links from DAG class's docstring to the sla_miss_callback section of tasks.rst where required.

image

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg

boring-cyborg Bot commented Sep 16, 2021

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 18, 2021
@potiuk potiuk closed this Sep 18, 2021
@potiuk potiuk reopened this Sep 18, 2021
@potiuk

potiuk commented Sep 18, 2021

Copy link
Copy Markdown
Member

close/reopen to rebuild

@potiuk
potiuk merged commit dcfa14d into apache:main Sep 18, 2021
@boring-cyborg

boring-cyborg Bot commented Sep 18, 2021

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request!

potiuk pushed a commit that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation on what each parameter to a sla_miss_callback callable is

2 participants