Visitar URL original
feat: Initial CLI for SSB integration by sydney-munro · Pull Request #2166 · googleapis/java-storage · GitHub
Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

feat: Initial CLI for SSB integration - #2166

Merged
sydney-munro merged 13 commits into
mainfrom
ssbcli
Aug 23, 2023
Merged

feat: Initial CLI for SSB integration#2166
sydney-munro merged 13 commits into
mainfrom
ssbcli

Conversation

@sydney-munro

@sydney-munro sydney-munro commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@sydney-munro
sydney-munro requested review from a team August 15, 2023 16:15
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Aug 15, 2023
@sydney-munro
sydney-munro marked this pull request as draft August 15, 2023 16:15
BenWhitehead
BenWhitehead suggested changes Aug 15, 2023
View reviewed changes
Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingCli.java Resolved
Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingCli.java Resolved
Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingCli.java Resolved
Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingCli.java Resolved
Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingCli.java
StorageOptions alwaysRetryStorageOptions =
StorageOptions.newBuilder().setProjectId(project).setRetrySettings(retrySettings).build();
Storage storageClient = alwaysRetryStorageOptions.getService();
Path tempDir = Paths.get(System.getProperty("java.io.tmpdir"));

@BenWhitehead BenWhitehead Aug 15, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want this to be an argument, sometimes java.io.tmpdir can be in a not so great place. (Not something that needs to change in this PR)

Comment thread ssb/src/main/java/com/google/cloud/StorageSharedBenchmarkingUtils.java Resolved
Comment thread ssb/pom.xml Resolved
Comment thread ssb/src/main/java/com/google/cloud/CloudMonitoringResult.java Resolved
Comment thread ssb/pom.xml Resolved
Comment thread ssb/pom.xml Resolved
@sydney-munro
sydney-munro force-pushed the ssbcli branch 2 times, most recently from ea179b9 to 5231f36 Compare August 17, 2023 13:57
@sydney-munro
sydney-munro marked this pull request as ready for review August 17, 2023 14:33
@product-auto-label product-auto-label Bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Aug 17, 2023
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Aug 17, 2023
@sydney-munro
sydney-munro merged commit a349735 into main Aug 23, 2023
@sydney-munro
sydney-munro deleted the ssbcli branch August 23, 2023 16:48
@release-please release-please Bot mentioned this pull request Aug 23, 2023
Merged
@lucymcnatt lucymcnatt mentioned this pull request Sep 29, 2023
Merged
5 of 9 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@BenWhitehead BenWhitehead BenWhitehead approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sydney-munro @BenWhitehead