Visitar URL original
feat: Follow-up CLI Improvements by sydney-munro · Pull Request #2184 · googleapis/java-storage · GitHub
Skip to content
This repository was archived by the owner on Sep 25, 2026. It is now read-only.

feat: Follow-up CLI Improvements - #2184

Merged
gcf-merge-on-green[bot] merged 2 commits into
mainfrom
cli-followup
Aug 30, 2023
Merged

gcf-merge-on-green[bot] merged 2 commits into
mainfrom
cli-followup

Conversation

@sydney-munro

Copy link
Copy Markdown
Contributor
  1. Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads
  2. Take in temporary directory as a CLI argument
  3. Utilize PrintWrite instead of System.out directly

1. Rename Workload1.java to W1R3 to prevent future confusion when it is used for other workloads
2. Take in temporary directory as a CLI argument
3. Utilize PrintWrite instead of System.out directly
@sydney-munro
sydney-munro requested a review from a team August 29, 2023 22:36
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels Aug 29, 2023

@BenWhitehead BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after enabling autoFlush on the PrintWriter

@sydney-munro sydney-munro added the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit d985976 into main Aug 30, 2023
@gcf-merge-on-green
gcf-merge-on-green Bot deleted the cli-followup branch August 30, 2023 21:08
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants