Visitar URL original
grpclb: Make ATTR_LB_ADDRS public. by susinmotion · Pull Request #7230 · grpc/grpc-java · GitHub
Skip to content

grpclb: Make ATTR_LB_ADDRS public. - #7230

Merged
voidzcy merged 1 commit into
grpc:masterfrom
susinmotion:patch-4
Jul 21, 2020
Merged

voidzcy merged 1 commit into
grpc:masterfrom
susinmotion:patch-4

Conversation

@susinmotion

Copy link
Copy Markdown
Contributor

This is used for an internal name resolver.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 17, 2020 •

Copy link
Copy Markdown

CLA Check
The committers are authorized under a signed CLA.

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having NameResolvers use the internal API, it seems exposing this is fair. ATTR_LB_ADDR_AUTHORITY is useless without this attribute.

@ejona86
ejona86 requested a review from voidzcy July 21, 2020 17:48
@ejona86 ejona86 changed the title Make ATTR_LB_ADDRS public. grpclb: Make ATTR_LB_ADDRS public. Jul 21, 2020
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 21, 2020
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 21, 2020
@voidzcy
voidzcy merged commit 2473110 into grpc:master Jul 21, 2020
dfawley pushed a commit to dfawley/grpc-java that referenced this pull request Jan 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants