Visitar URL original
okhttp: introduced new TLS1.2 cipher suites and internal okhttp implementation for TLS1.3 prepared. by beatrausch · Pull Request #8650 · grpc/grpc-java · GitHub
Skip to content

okhttp: introduced new TLS1.2 cipher suites and internal okhttp implementation for TLS1.3 prepared. - #8650

Merged
ejona86 merged 3 commits into
grpc:masterfrom
beatrausch:okhttp-additional-ciphers
Nov 17, 2021
Merged

okhttp: introduced new TLS1.2 cipher suites and internal okhttp implementation for TLS1.3 prepared. #8650
ejona86 merged 3 commits into
grpc:masterfrom
beatrausch:okhttp-additional-ciphers

Conversation

@beatrausch

@beatrausch beatrausch commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

The PR introduces new TLS 1.2 cipher suites (#8610) and prepares the internal okhttp implementation for TLS1.3. A new method for using a internal ConnectionSpec was added to be able to use the newly introduced cipher suites in the OkHttpChannelBuilder. Okhttp cipher suites synchronized with the ones form netty.

@linux-foundation-easycla

linux-foundation-easycla Bot commented Nov 3, 2021 •
edited
Loading

Copy link
Copy Markdown

CLA Signed

The committers are authorized under a signed CLA.

@ejona86

ejona86 commented Nov 3, 2021

Copy link
Copy Markdown
Member

CC @dapengzhang0

We can't review until you agree to the CLA. If you have trouble, just tell us.

@beatrausch

beatrausch commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

CC @dapengzhang0

We can't review until you agree to the CLA. If you have trouble, just tell us.

I agreed the CLA, but it seems that I used the wrong username for my initial commit. Is there a way to change this? or shall I close the PR and create a new one with the commits issued with the correct username?

@ejona86

ejona86 commented Nov 3, 2021

Copy link
Copy Markdown
Member

@beatrausch, you can do whatever rewriting of the commits you need (e.g., via rebase) and then just force-push to your fork's branch. This PR will track that branch, and then notice the new authorship.

@beatrausch
Okhttp cipher suites for TLS1.3 prepared
49fd62a 
Additional TLS1.2 cipher suites added
Default connection spec synced with netty
Introduced new method for internal connection in OkHttpChannelBuilder
@beatrausch
checkstyle issues fixed
b861c5e
@beatrausch
beatrausch force-pushed the okhttp-additional-ciphers branch from daf3c20 to cdb8dc5 Compare November 4, 2021 07:22
@dapengzhang0

dapengzhang0 commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

@beatrausch Can you please drop unrelated commits?

@beatrausch
beatrausch force-pushed the okhttp-additional-ciphers branch from cdb8dc5 to b861c5e Compare November 9, 2021 19:48
@beatrausch

beatrausch commented Nov 9, 2021

Copy link
Copy Markdown
Contributor Author

@beatrausch Can you please drop unrelated commits?

Sorry, I dropped the commits

ejona86
ejona86 reviewed Nov 11, 2021
View reviewed changes
Comment thread okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java Resolved
Comment thread okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java Resolved
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 12, 2021
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 12, 2021
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 16, 2021
@ejona86
ejona86 requested a review from dapengzhang0 November 16, 2021 20:08
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 16, 2021
@ejona86
ejona86 merged commit 5a3b8e2 into grpc:master Nov 17, 2021
@ejona86

ejona86 commented Nov 17, 2021

Copy link
Copy Markdown
Member

@beatrausch, thank you!

@ejona86 ejona86 mentioned this pull request Nov 17, 2021
Closed
@beatrausch
beatrausch deleted the okhttp-additional-ciphers branch November 17, 2021 19:13
@ejona86 ejona86 mentioned this pull request Dec 2, 2021
Closed
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes
+1 more reviewer
@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@beatrausch @ejona86 @dapengzhang0 @grpc-kokoro